Merge pull request #62 from eosdis-nasa/hotfix-approve-privilage-fix

Fix privilege check for approval

Author: DavisGauntUAH

src/nodejs/lambda-handlers/submission.js

@@ -148,10 +148,10 @@ async function submitMethod(event, user) {
 }
 
 async function reviewMethod(event, user) {
-  const approvedUserRoles = ['ADMIN', 'REQUEST_REVIEW', 'REQUEST_REVIEW_MANAGER'];
+  const approvedUserPrivileges = ['ADMIN', 'REQUEST_REVIEW', 'REQUEST_REVIEW_MANAGER'];
   const { id, approve } = event;
   const status = await db.submission.getState({ id });
-  if (user.user_roles.some((role) => approvedUserRoles.includes(role.short_name))) {
+  if (user.user_privileges.some((privilege) => approvedUserPrivileges.includes(privilege))) {
     const stepType = status.step.type;
     let eventType;
     if (approve === 'false' || !approve) {

src/nodejs/lambda-handlers/test/handlers/submission.test.js

@@ -177,7 +177,7 @@ describe('submission', () => {
       id: 'test id',
       approve: true
     };
-    db.user.findById.mockReturnValue({ id: 'test user', user_roles: [{ short_name: 'REQUEST_REVIEW' }] });
+    db.user.findById.mockReturnValue({ id: 'test user', user_privileges: ['REQUEST_REVIEW'] });
     db.submission.getState.mockReturnValue({
       conversation_id: 'test conversation',
       workflow_id: 'test workflow',