Skip to content

Commit 15af025

Browse files
danehansArko Dasgupta
authored andcommitted
Updates Envoy Cert as Wildcard Hostname
Signed-off-by: danehans <[email protected]>
1 parent 4b811b8 commit 15af025

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

internal/crypto/certgen.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const (
2121
DefaultEnvoyGatewayDNSPrefix = config.EnvoyGatewayServiceName
2222

2323
// DefaultEnvoyDNSPrefix defines the default Envoy DNS prefix.
24-
DefaultEnvoyDNSPrefix = config.EnvoyServiceName
24+
DefaultEnvoyDNSPrefix = "*"
2525

2626
// DefaultNamespace is the default Namespace name where Envoy Gateway is running.
2727
DefaultNamespace = config.EnvoyGatewayNamespace
@@ -112,7 +112,7 @@ func GenerateCerts(egCfg *v1alpha1.EnvoyGateway) (*Certificates, error) {
112112
switch egProvider {
113113
case v1alpha1.ProviderTypeKubernetes:
114114
egDNSNames = kubeServiceNames(DefaultEnvoyGatewayDNSPrefix, DefaultNamespace, DefaultDNSSuffix)
115-
envoyDNSNames = kubeServiceNames(DefaultEnvoyDNSPrefix, DefaultNamespace, DefaultDNSSuffix)
115+
envoyDNSNames = append(envoyDNSNames, fmt.Sprintf("*.%s", DefaultNamespace))
116116
default:
117117
// Kubernetes is the only supported Envoy Gateway provider.
118118
return nil, fmt.Errorf("unsupported provider type %v", egProvider)

internal/crypto/certgen_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func TestGenerateCerts(t *testing.T) {
4747
run(t, "no configuration - use defaults", testcase{
4848
certConfig: &Configuration{},
4949
wantEnvoyGatewayDNSName: "envoy-gateway",
50-
wantEnvoyDNSName: "envoy",
50+
wantEnvoyDNSName: "*.envoy-gateway-system",
5151
})
5252
}
5353

0 commit comments

Comments
 (0)