Skip to content

deps: bzlmod migration with BCR dependencies #42190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: bzlmod migration with BCR dependencies #42190

wants to merge 1 commit into from
+1,136 −1,465

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 22, 2025

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Nov 22, 2025

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42190 was opened by mmorel-35.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 22, 2025
@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Nov 22, 2025

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #42190 was opened by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 3 times, most recently from 3cf696c to 2ab02ca Compare November 22, 2025 13:49
@mmorel-35 mmorel-35 changed the title deps: bzlmod migration with BCR dependencies and non-module extension deps: bzlmod migration with BCR dependencies Nov 22, 2025
@mmorel-35 mmorel-35 marked this pull request as ready for review November 22, 2025 14:03
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
MODULE.bazel
bazel_dep(name = "bazel_features", version = "1.38.0")
bazel_dep(name = "bazel_skylib", version = "1.8.2")
bazel_dep(name = "boringssl", version = "0.20250514.0")
bazel_dep(name = "brotli", version = "1.1.0", repo_name = "org_brotli")
Copy link
Contributor

@moderation moderation Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version at 1.2.0. Update

Copy link
Contributor Author

@mmorel-35 mmorel-35 Nov 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not in BCR yet, I created bazelbuild/bazel-central-registry#6618 and google/brotli#1395

moderation
moderation reviewed Nov 23, 2025
View reviewed changes
MODULE.bazel Outdated
bazel_dep(name = "bazel_skylib", version = "1.8.2")
bazel_dep(name = "boringssl", version = "0.20250514.0")
bazel_dep(name = "brotli", version = "1.1.0", repo_name = "org_brotli")
bazel_dep(name = "cel-spec", version = "0.24.0", repo_name = "dev_cel")
Copy link
Contributor

@moderation moderation Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version at 0.25.0. Update

Copy link
Contributor Author

@mmorel-35 mmorel-35 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/cel-spec/0.25.1 is available in BCR, I created google/cel-spec#498

moderation
moderation reviewed Nov 23, 2025
View reviewed changes
MODULE.bazel Outdated
bazel_dep(name = "envoy_build_config", version = "1.37.0-dev")
bazel_dep(name = "envoy_mobile", version = "1.37.0-dev")
bazel_dep(name = "fast_float", version = "8.0.2")
bazel_dep(name = "flatbuffers", version = "25.2.10", repo_name = "com_github_google_flatbuffers")
Copy link
Contributor

@moderation moderation Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version at 25.9.23. Update

Copy link
Contributor Author

@mmorel-35 mmorel-35 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not in BCR yet, I created bazelbuild/bazel-central-registry#6619 and google/flatbuffers#8801

moderation
moderation reviewed Nov 23, 2025
View reviewed changes
MODULE.bazel
bazel_dep(name = "fmt", version = "12.1.0", repo_name = "com_github_fmtlib_fmt")
bazel_dep(name = "gazelle", version = "0.47.0", repo_name = "bazel_gazelle")
bazel_dep(name = "googleapis", version = "0.0.0-20241220-5e258e33.bcr.1", repo_name = "com_google_googleapis")
bazel_dep(name = "googleurl", repo_name = "com_googlesource_googleurl")
Copy link
Contributor

@moderation moderation Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs version. Current version at dd4080fec0b443296c0ed0036e1e776df8813aa7

moderation
moderation reviewed Nov 23, 2025
View reviewed changes
MODULE.bazel
bazel_dep(name = "fmt", version = "12.1.0", repo_name = "com_github_fmtlib_fmt")
bazel_dep(name = "gazelle", version = "0.47.0", repo_name = "bazel_gazelle")
bazel_dep(name = "googleapis", version = "0.0.0-20241220-5e258e33.bcr.1", repo_name = "com_google_googleapis")
bazel_dep(name = "googleurl", repo_name = "com_googlesource_googleurl")
Copy link
Contributor

@moderation moderation Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs version. Current version at dd4080fec0b443296c0ed0036e1e776df8813aa7

moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
moderation
moderation reviewed Nov 23, 2025
View reviewed changes
MODULE.bazel
Comment on lines +201 to +209
python.toolchain(
is_default = True,
python_version = "3.12",
)
use_repo(
python,
"python_3_12",
python = "python_versions",
)
Copy link
Contributor

@moderation moderation Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Python 3.14 out, can this be bumped to at least 3.13?

Copy link
Member

@phlax phlax Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python update should be handled separately - 3.13 added a lot of breaking change so ive held off so far

moderation
moderation reviewed Nov 23, 2025
View reviewed changes
MODULE.bazel
Comment on lines +201 to +209
python.toolchain(
is_default = True,
python_version = "3.12",
)
use_repo(
python,
"python_3_12",
python = "python_versions",
)
Copy link
Contributor

@moderation moderation Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Python 3.14 out, can this be bumped to at least 3.13?

moderation
moderation suggested changes Nov 23, 2025
View reviewed changes
Copy link
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big change to dependency management and will need Bazel expert review and more @envoyproxy/dependency-shepherds eyes.

@phlax phlax self-assigned this Nov 23, 2025
@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 2 times, most recently from fa2ddf1 to a2b4153 Compare November 23, 2025 10:14
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 23, 2025

Blocked by #42194

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 4 times, most recently from 1fe0650 to 7c19380 Compare November 26, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlax phlax phlax left review comments

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist is a code owner

@abeyad abeyad Awaiting requested review from abeyad abeyad is a code owner

@danzh2010 danzh2010 Awaiting requested review from danzh2010 danzh2010 is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123

@mathetake mathetake Awaiting requested review from mathetake

+1 more reviewer

@moderation moderation moderation requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@moderation moderation

@phlax phlax

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmorel-35 @moderation @phlax