moved error code enumerations to the result of action messages (ros-navigation#3693)

* moved error code enumerations to the result of action messages

* test fixes

* code review

Signed-off-by: enricosutera <[email protected]>

Author: jwallace42

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/assisted_teleop_action.hpp

@@ -30,7 +30,6 @@ namespace nav2_behavior_tree
 class AssistedTeleopAction : public BtActionNode<nav2_msgs::action::AssistedTeleop>
 {
   using Action = nav2_msgs::action::AssistedTeleop;
-  using ActionGoal = Action::Goal;
   using ActionResult = Action::Result;
 
 public:

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/back_up_action.hpp

@@ -29,7 +29,6 @@ namespace nav2_behavior_tree
 class BackUpAction : public BtActionNode<nav2_msgs::action::BackUp>
 {
   using Action = nav2_msgs::action::BackUp;
-  using ActionGoal = Action::Goal;
   using ActionResult = Action::Result;
 
 public:

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/compute_path_through_poses_action.hpp

@@ -34,7 +34,6 @@ class ComputePathThroughPosesAction
 {
   using Action = nav2_msgs::action::ComputePathThroughPoses;
   using ActionResult = Action::Result;
-  using ActionGoal = Action::Goal;
 
 public:
   /**

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/compute_path_to_pose_action.hpp

@@ -31,7 +31,6 @@ class ComputePathToPoseAction : public BtActionNode<nav2_msgs::action::ComputePa
 {
   using Action = nav2_msgs::action::ComputePathToPose;
   using ActionResult = Action::Result;
-  using ActionGoal = Action::Goal;
 
 public:
   /**

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/drive_on_heading_action.hpp

@@ -29,8 +29,7 @@ namespace nav2_behavior_tree
 class DriveOnHeadingAction : public BtActionNode<nav2_msgs::action::DriveOnHeading>
 {
   using Action = nav2_msgs::action::DriveOnHeading;
-  using ActionGoal = Action::Goal;
-  using ActionResult = Action::Goal;
+  using ActionResult = Action::Result;
 
 public:
   /**

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/follow_path_action.hpp

@@ -31,7 +31,6 @@ class FollowPathAction : public BtActionNode<nav2_msgs::action::FollowPath>
 {
   using Action = nav2_msgs::action::FollowPath;
   using ActionResult = Action::Result;
-  using ActionGoal = Action::Goal;
 
 public:
   /**

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/navigate_through_poses_action.hpp

@@ -33,7 +33,6 @@ class NavigateThroughPosesAction : public BtActionNode<nav2_msgs::action::Naviga
 {
   using Action = nav2_msgs::action::NavigateThroughPoses;
   using ActionResult = Action::Result;
-  using ActionGoal = Action::Goal;
 
 public:
   /**

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/navigate_to_pose_action.hpp

@@ -32,7 +32,6 @@ class NavigateToPoseAction : public BtActionNode<nav2_msgs::action::NavigateToPo
 {
   using Action = nav2_msgs::action::NavigateToPose;
   using ActionResult = Action::Result;
-  using ActionGoal = Action::Goal;
 
 public:
   /**

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/smooth_path_action.hpp

@@ -32,7 +32,6 @@ class SmoothPathAction : public nav2_behavior_tree::BtActionNode<nav2_msgs::acti
 {
   using Action = nav2_msgs::action::SmoothPath;
   using ActionResult = Action::Result;
-  using ActionGoal = Action::Goal;
 
 public:
   /**

nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/spin_action.hpp

@@ -30,7 +30,6 @@ class SpinAction : public BtActionNode<nav2_msgs::action::Spin>
 {
   using Action = nav2_msgs::action::Spin;
   using ActionResult = Action::Result;
-  using ActionGoal = Action::Goal;
 
 public:
   /**