Rename helm resources #29

plaffitt · 2023-02-03T15:15:34Z

This PR tries to harmonize naming between helm resources and fix some naming issues as well.

Registry statefulset was originally named "cache-registry" at the time the project was also called "cache-registry". Thus, when reworking the chart, its name was replaced by a template to name it by the name of the project. Then, when the project was renamed kube-image-keeper, the registry name was templated as kube-image-keeper instead of cache-registry. This commit intend to fix this mistake and set a proper name for the registry.
All resources are now prefixed with the kube-image-keeper.fullname helper, which by default when following the installation steps in the readme is kuik. It still can be customized using values nameOverride and fullnameOverride or by giving another name than the standard one (kube-image-keeper) to the helm release. It follows those rules (see test-helm-fullname-helper.sh file for examples) :
- Fullname = releaseName-name
- By default, name = "kuik" but it can be overridden by specifying nameOverride value
- If the release is named "kube-image-keeper", then it is shortened as "kuik" in the fullname
- If releaseName contains name it will be used as a full name to avoid repetition.
- The fullname can be completely overridden by specifying fullnameOverride value

⚠️ The renaming create a new PVC for the registry, thus invalidate the cache.

helm/kube-image-keeper/templates/service.yaml

It was originally named "cache-registry" at the time the project was also called "cache-registry". Thus, when reworking the chart, its name was replaced by a template to name it by the name of the project. Then, when the project was renamed kube-image-keeper, the registry name was templated as kube-image-keeper instead of cache-registry. This commit intend to fix this mistake and set a proper name for the registry. cjob

jpetazzo · 2023-02-07T16:49:50Z

I like it!

$ helm template kube-image-keeper helm/kube-image-keeper/ | grep -e '^  name:' -e ^kind
kind: ServiceAccount
  name: kuik-registry-restart
kind: ServiceAccount
  name: kuik-controllers
kind: CustomResourceDefinition
  name: cachedimages.kuik.enix.io
kind: ClusterRole
  name: kuik-controllers
kind: ClusterRole
  name: kuik-controllers-leader-election
kind: ClusterRoleBinding
  name: kuik-controllers
  name: kuik-controllers
kind: ClusterRoleBinding
  name: kuik-controllers-leader-election
  name: kuik-controllers-leader-election
kind: Role
  name: kuik-registry-restart
kind: RoleBinding
  name: kuik-registry-restart
  name: kuik-registry-restart
kind: Service
  name: kuik-registry
kind: Service
  name: kuik-webhook
kind: DaemonSet
  name: kuik-proxy
kind: Deployment
  name: kuik-controllers
kind: StatefulSet
  name: kuik-registry
kind: Certificate
  name: kuik-serving-cert
kind: Issuer
  name: kuik-selfsigned-issuer
kind: MutatingWebhookConfiguration
  name: kuik-mutating-webhook
  name: mpod.kb.io

SGTM 💯

cmd/cache/main.go

helm/kube-image-keeper/templates/registry-statefulset.yaml

internal/registry/registry.go

monkeynator · 2023-04-07T14:44:11Z