Skip to content

Commit c2309f3

Browse files
authored
Fix NavigationBar example overflow alignment (#159034)
Fix the NavigationBar example overflow alignment. ### Before: <img src="https://github.com/user-attachments/assets/a6cf2cbb-ac32-482c-9aed-8cac15152a0d" height="450" /> ### After: <img src="https://github.com/user-attachments/assets/d476c617-edd3-449d-93cf-4a9a87c26d98" height="450" /> *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 0571df9 commit c2309f3

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

examples/api/lib/material/navigation_bar/navigation_bar.1.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,8 @@ class _NavigationExampleState extends State<NavigationExample> {
6363
const SizedBox(height: 10),
6464
OverflowBar(
6565
spacing: 10.0,
66+
overflowAlignment: OverflowBarAlignment.center,
67+
overflowSpacing: 10.0,
6668
children: <Widget>[
6769
ElevatedButton(
6870
onPressed: () {

examples/api/test/material/navigation_bar/navigation_bar.1_test.dart

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@ void main() {
3838

3939
expect(find.text('Label behavior: alwaysHide'), findsOneWidget);
4040
navigationBarWidget = tester.firstWidget(find.byType(NavigationBar));
41-
expect(navigationBarWidget.labelBehavior, NavigationDestinationLabelBehavior.alwaysHide);
41+
expect(
42+
navigationBarWidget.labelBehavior,
43+
NavigationDestinationLabelBehavior.alwaysHide,
44+
);
45+
});
46+
47+
testWidgets('Overflow buttons are aligned in the center', (WidgetTester tester) async {
48+
await tester.pumpWidget(const example.NavigationBarApp());
49+
50+
final OverflowBar overflowBar = tester.widget<OverflowBar>(find.byType(OverflowBar));
51+
expect(overflowBar.overflowAlignment, OverflowBarAlignment.center);
52+
expect(overflowBar.overflowSpacing, 10.0);
4253
});
4354
}

0 commit comments

Comments
 (0)