Skip to content

Commit 5b0706c

Browse files
authored
Re-split hot reload error and hot restart tests (#170368)
After [combining](flutter/flutter#169860) these 2 tests, they became very flaky, especially on Mac and Windows, but also on Linux. Filed an issue: flutter/flutter#170062
1 parent 8303a96 commit 5b0706c

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

packages/flutter_tools/test/integration.shard/test_data/hot_reload_errors_common.dart

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ void testAll({
3434
});
3535

3636
testWithoutContext(
37-
'hot reload displays a formatted error message when removing a field from a const class, and hot restart succeeds',
37+
'hot reload displays a formatted error message when removing a field from a const class',
3838
() async {
3939
await flutter.run(
4040
device:
@@ -53,9 +53,16 @@ void testAll({
5353
),
5454
),
5555
);
56-
57-
await expectLater(flutter.hotRestart(), completes);
5856
},
5957
);
58+
59+
testWithoutContext('hot restart succeeds when removing a field from a const class', () async {
60+
await flutter.run(
61+
device: chrome ? GoogleChromeDevice.kChromeDeviceId : FlutterTesterDevices.kTesterDeviceId,
62+
additionalCommandArgs: additionalCommandArgs,
63+
);
64+
project.removeFieldFromConstClass();
65+
await expectLater(flutter.hotRestart(), completes);
66+
});
6067
});
6168
}

packages/flutter_tools/test/web.shard/hot_reload_web_errors_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@TestOn('linux') // https://github.com/flutter/flutter/issues/170062
65
@Tags(<String>['flutter-test-driver'])
76
library;
87

0 commit comments

Comments
 (0)