[CP-stable]Migrate module templates to declarative application of the Flutter Gradle Plugin (#160090)

This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

flutter/flutter#159729

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

flutter/flutter#159729: Warning in logs after a fresh flutter module create when building an aar for android. 

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Warning after flutter create of a module. 

### Workaround:
Is there a workaround for this issue?

Manual migration after flutter create. 

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

create module then build as app or aar then look in logs for warnings about gradle imperative apply

Author: flutteractionsbot

dev/devicelab/bin/tasks/build_android_host_app_with_module_aar.dart

@@ -41,6 +41,8 @@ class ModuleTest {
 
   static const String buildTarget = 'module-gradle';
   final String gradleVersion;
+  final StringBuffer stdout = StringBuffer();
+  final StringBuffer stderr = StringBuffer();
 
   Future<TaskResult> call() async {
     section('Running: $buildTarget-$gradleVersion');
@@ -61,6 +63,8 @@ class ModuleTest {
         await flutter(
           'create',
           options: <String>['--org', 'io.flutter.devicelab', '--template=module', 'hello'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -69,6 +73,8 @@ class ModuleTest {
       await flutter(
         'config',
         options: <String>['--enable-native-assets'],
+        output: stdout,
+        stderr: stderr,
       );
 
       const String ffiPackageName = 'ffi_package';
@@ -87,6 +93,8 @@ class ModuleTest {
         await flutter(
           'packages',
           options: <String>['get'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -127,6 +135,8 @@ class ModuleTest {
         await flutter(
           'packages',
           options: <String>['get'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -162,6 +172,8 @@ class ModuleTest {
         await flutter(
           'build',
           options: <String>['apk'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -182,7 +194,11 @@ class ModuleTest {
       section('Clean build');
 
       await inDirectory(projectDir, () async {
-        await flutter('clean');
+        await flutter(
+          'clean',
+          output: stdout,
+          stderr: stderr,
+        );
       });
 
       section('Make Android host app editable');
@@ -191,6 +207,8 @@ class ModuleTest {
         await flutter(
           'make-host-app-editable',
           options: <String>['android'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -200,6 +218,8 @@ class ModuleTest {
         await flutter(
           'build',
           options: <String>['apk'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -435,6 +455,12 @@ class ModuleTest {
         return TaskResult.failure('Failed to make assets user-readable and writable');
       }
 
+      section('Check for specific log errors.');
+      final String finalStderr = stderr.toString();
+      if (finalStderr.contains("You are applying Flutter's main Gradle plugin imperatively")) {
+        return TaskResult.failure('Applied the Flutter Gradle Plugin imperatively');
+      }
+
       return TaskResult.success(null);
     } on TaskResult catch (taskResult) {
       return taskResult;

dev/devicelab/bin/tasks/build_android_host_app_with_module_source.dart

@@ -41,6 +41,8 @@ class ModuleTest {
 
   static const String buildTarget = 'module-gradle';
   final String gradleVersion;
+  final StringBuffer stdout = StringBuffer();
+  final StringBuffer stderr = StringBuffer();
 
   Future<TaskResult> call() async {
     section('Running: $buildTarget-$gradleVersion');
@@ -61,6 +63,8 @@ class ModuleTest {
         await flutter(
           'create',
           options: <String>['--org', 'io.flutter.devicelab', '--template=module', 'hello'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -69,6 +73,8 @@ class ModuleTest {
       await flutter(
         'config',
         options: <String>['--enable-native-assets'],
+        output: stdout,
+        stderr: stderr,
       );
 
       const String ffiPackageName = 'ffi_package';
@@ -87,6 +93,8 @@ class ModuleTest {
         await flutter(
           'packages',
           options: <String>['get'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -127,6 +135,8 @@ class ModuleTest {
         await flutter(
           'packages',
           options: <String>['get'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -136,6 +146,8 @@ class ModuleTest {
         await flutter(
           'build',
           options: <String>['apk'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -156,7 +168,11 @@ class ModuleTest {
       section('Clean build');
 
       await inDirectory(projectDir, () async {
-        await flutter('clean');
+        await flutter(
+          'clean',
+          output: stdout,
+          stderr: stderr,
+        );
       });
 
       section('Make Android host app editable');
@@ -165,6 +181,8 @@ class ModuleTest {
         await flutter(
           'make-host-app-editable',
           options: <String>['android'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -174,6 +192,8 @@ class ModuleTest {
         await flutter(
           'build',
           options: <String>['apk'],
+          output: stdout,
+          stderr: stderr,
         );
       });
 
@@ -411,6 +431,12 @@ class ModuleTest {
         return TaskResult.failure('Failed to make assets user-readable and writable');
       }
 
+      section('Check for specific log errors.');
+      final String finalStderr = stderr.toString();
+      if (finalStderr.contains("You are applying Flutter's main Gradle plugin imperatively")) {
+        return TaskResult.failure('Applied the Flutter Gradle Plugin imperatively');
+      }
+
       return TaskResult.success(null);
     } on TaskResult catch (taskResult) {
       return taskResult;

dev/devicelab/lib/framework/utils.dart

@@ -514,12 +514,21 @@ Future<int> flutter(String command, {
                               // DevToolsMemoryTest in perf_tests.dart.
   Map<String, String>? environment,
   String? workingDirectory,
+  StringBuffer? output, // if not null, the stdout will be written here
+  StringBuffer? stderr, // if not null, the stderr will be written here
 }) async {
   final List<String> args = _flutterCommandArgs(
     command, options, driveWithDds: driveWithDds,
   );
-  final int exitCode = await exec(path.join(flutterDirectory.path, 'bin', 'flutter'), args,
-    canFail: canFail, environment: environment, workingDirectory: workingDirectory);
+  final int exitCode = await exec(
+      path.join(flutterDirectory.path, 'bin', 'flutter'),
+      args,
+      canFail: canFail,
+      environment: environment,
+      workingDirectory: workingDirectory,
+      output: output,
+      stderr: stderr,
+  );
 
   if (exitCode != 0 && !canFail) {
     await _flutterScreenshot(workingDirectory: workingDirectory);

packages/flutter_tools/gradle/aar_init_script.gradle

@@ -157,6 +157,10 @@ projectsEvaluated {
         configureProject(rootProject, rootProject.property("output-dir"))
         return
     }
+    if (rootProject.name == "gradle") {
+        // Skip the "gradle" project, we are looking only for the "android_generated" project.
+        return
+    }
     // The module project is the `:flutter` subproject.
     Project moduleProject = rootProject.subprojects.find { it.name == "flutter" }
     assert moduleProject != null

packages/flutter_tools/templates/module/android/gradle/build.gradle.tmpl

@@ -1,18 +1,5 @@
 // Generated file. Do not edit.
 
-buildscript {
-    ext.kotlin_version = "{{kotlinVersion}}"
-    repositories {
-        google()
-        mavenCentral()
-    }
-
-    dependencies {
-        classpath("com.android.tools.build:gradle:{{agpVersionForModule}}")
-        classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version")
-    }
-}
-
 allprojects {
     repositories {
         google()
@@ -31,7 +18,3 @@ android {
         targetSdk = {{targetSdkVersion}}
     }
 }
-
-dependencies {
-    implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version")
-}

packages/flutter_tools/templates/module/android/host_app_ephemeral/settings.gradle.copy.tmpl

@@ -0,0 +1,31 @@
+// Generated file. Do not edit.
+
+pluginManagement {
+    def flutterSdkPath = {
+        def properties = new Properties()
+        file("local.properties").withInputStream { properties.load(it) }
+        def flutterSdkPath = properties.getProperty("flutter.sdk")
+        assert flutterSdkPath != null, "flutter.sdk not set in local.properties"
+        return flutterSdkPath
+    }()
+
+    includeBuild("$flutterSdkPath/packages/flutter_tools/gradle")
+
+    repositories {
+        google()
+        mavenCentral()
+        gradlePluginPortal()
+    }
+}
+
+plugins {
+    id "dev.flutter.flutter-plugin-loader" version "1.0.0"
+    id "com.android.library" version "{{agpVersionForModule}}" apply false
+    id "org.jetbrains.kotlin.android" version "{{kotlinVersion}}" apply false
+}
+
+include ':app'
+
+rootProject.name = 'android_generated'
+setBinding(new Binding([gradle: this]))
+evaluate(new File(settingsDir, 'include_flutter.groovy'))

packages/flutter_tools/templates/module/android/host_app_ephemeral/settings.gradle.tmpl

@@ -1,5 +1,10 @@
 // Generated file. Do not edit.
 
+plugins {
+    id "com.android.library"
+    id "dev.flutter.flutter-gradle-plugin"
+}
+
 def localProperties = new Properties()
 def localPropertiesFile = new File(buildscript.sourceFile.parentFile.parentFile, "local.properties")
 if (localPropertiesFile.exists()) {
@@ -8,11 +13,6 @@ if (localPropertiesFile.exists()) {
     }
 }
 
-def flutterRoot = localProperties.getProperty("flutter.sdk")
-if (flutterRoot == null) {
-    throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
-}
-
 def flutterVersionCode = localProperties.getProperty("flutter.versionCode")
 if (flutterVersionCode == null) {
     flutterVersionCode = "1"
@@ -23,9 +23,6 @@ if (flutterVersionName == null) {
     flutterVersionName = "1.0"
 }
 
-apply plugin: "com.android.library"
-apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
-
 group = "{{androidIdentifier}}"
 version = "1.0"
 

packages/flutter_tools/templates/module/android/library_new_embedding/Flutter.tmpl/build.gradle.tmpl

@@ -26,3 +26,7 @@ localPropertiesFile.withReader("UTF-8") { reader -> properties.load(reader) }
 def flutterSdkPath = properties.getProperty("flutter.sdk")
 assert flutterSdkPath != null, "flutter.sdk not set in local.properties"
 gradle.apply from: "$flutterSdkPath/packages/flutter_tools/gradle/module_plugin_loader.gradle"
+
+gradle.pluginManagement{
+    includeBuild("$flutterSdkPath/packages/flutter_tools/gradle")
+}

packages/flutter_tools/templates/module/android/library_new_embedding/include_flutter.groovy.copy.tmpl

@@ -164,7 +164,7 @@
         "templates/module/android/host_app_common/app.tmpl/src/main/res/mipmap-hdpi/ic_launcher.png",
         "templates/module/android/host_app_common/app.tmpl/src/main/res/values/styles.xml",
         "templates/module/android/host_app_editable/settings.gradle.copy.tmpl",
-        "templates/module/android/host_app_ephemeral/settings.gradle.copy.tmpl",
+        "templates/module/android/host_app_ephemeral/settings.gradle.tmpl",
         "templates/module/android/library/Flutter.tmpl/build.gradle.tmpl",
         "templates/module/android/library/Flutter.tmpl/flutter.iml.copy.tmpl",
         "templates/module/android/library/Flutter.tmpl/src/main/AndroidManifest.xml.tmpl",