Skip to content

Commit 422d8d2

Browse files
authored
[tests] Increase linux timeout and skip on others (#169627)
With this change the web.shard test suite runs all existing tests on all platforms with the version of the web debug builds that is the flutter tools default (does not support stateful hot reload). The linux bot configuration will also run some of the tests using the new web debug build (supports stateful hot reload). The timeout has been increased for this configuration to allow the additional tests to run to completion. The mac and windows configurations skip all tests for the new web debug builds. In the future the new build output will become the flutter tools default and the balance of where the tests tests are run will flip until the ability to opt out of the new build output is removed. This change is not ideal because we are still not fully testing all features with the two versions of the web debug builds that are available to users. If given the opportunity we should add additional bot configurations to run all the tests with the output that supports stateful hot reload. Fixes: flutter/flutter#169304 Issue: flutter/flutter#169634
1 parent fe1c9d6 commit 422d8d2

8 files changed

Lines changed: 8 additions & 4 deletions

.ci.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2246,7 +2246,7 @@ targets:
22462246

22472247
- name: Linux web_tool_tests
22482248
recipe: flutter/flutter_drone
2249-
timeout: 60
2249+
timeout: 90 # https://github.com/flutter/flutter/issues/169634
22502250
properties:
22512251
dependencies: >-
22522252
[
@@ -2261,7 +2261,7 @@ targets:
22612261
["framework", "hostonly", "shard", "linux"]
22622262
# Retry for flakes caused by https://github.com/flutter/flutter/issues/132654
22632263
presubmit_max_attempts: "2"
2264-
test_timeout_secs: "3600" # https://github.com/flutter/flutter/issues/162714
2264+
test_timeout_secs: "5400" # https://github.com/flutter/flutter/issues/162714
22652265
runIf:
22662266
- dev/**
22672267
- packages/flutter_tools/**

packages/flutter_tools/test/web.shard/expression_evaluation_web_amd_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// found in the LICENSE file.
44

55
@Tags(<String>['flutter-test-driver'])
6-
@Skip('https://github.com/flutter/flutter/issues/169304')
76
library;
87

98
import '../src/common.dart';

packages/flutter_tools/test/web.shard/expression_evaluation_web_ddc_library_bundle_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
56
@Tags(<String>['flutter-test-driver'])
6-
@Skip('https://github.com/flutter/flutter/issues/169304')
77
library;
88

99
import '../src/common.dart';

packages/flutter_tools/test/web.shard/hot_reload_web_errors_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
56
@Tags(<String>['flutter-test-driver'])
67
library;
78

packages/flutter_tools/test/web.shard/hot_reload_web_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
56
@Tags(<String>['flutter-test-driver'])
67
library;
78

packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
56
@Tags(<String>['flutter-test-driver'])
67
library;
78

packages/flutter_tools/test/web.shard/hot_restart_web_ddc_library_bundle_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
56
@Tags(<String>['flutter-test-driver'])
67
library;
78

packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
@TestOn('linux') // https://github.com/flutter/flutter/issues/169304
56
@Tags(<String>['flutter-test-driver'])
67
library;
78

0 commit comments

Comments
 (0)