Reland "Add a buildtools directory and move third_party/ninja to the project root in order to match the expectations of depot_tools" (#164240)

Relands flutter/flutter#163890 and updates the
Ninja path used by the engine tool

Author: jason-simmons

DEPS

@@ -637,7 +637,7 @@ deps = {
     ],
     'dep_type': 'cipd',
   },
-  'engine/src/flutter/third_party/ninja': {
+  'third_party/ninja': {
     'packages': [
       {
         'package': 'infra/3pp/tools/ninja/${{platform}}',

buildtools/README.md

@@ -0,0 +1 @@
+This directory is a placeholder intended to make Flutter's source tree match the expectations of [depot_tools](https://www.chromium.org/developers/how-tos/depottools/), which is used to build the Flutter engine.

dev/bots/analyze.dart

@@ -1632,6 +1632,7 @@ Future<void> verifyRepositoryLinks(String workingDirectory) async {
     'glfw/glfw',
     'GoogleCloudPlatform/artifact-registry-maven-tools',
     'material-components/material-components-android', // TODO(guidezpl): remove when https://github.com/material-components/material-components-android/issues/4144 is closed
+    'ninja-build/ninja',
     'torvalds/linux',
     'tpn/winsdk-10',
   };

engine/src/flutter/ci/licenses_golden/excluded_files

@@ -2295,7 +2295,6 @@
 ../../../flutter/third_party/libwebp/swig
 ../../../flutter/third_party/libwebp/tests
 ../../../flutter/third_party/libwebp/webp_js
-../../../flutter/third_party/ninja
 ../../../flutter/third_party/ocmock
 ../../../flutter/third_party/perfetto/.clang-format
 ../../../flutter/third_party/perfetto/.clang-tidy

engine/src/flutter/tools/pkg/engine_build_configs/lib/src/build_config_runner.dart

@@ -583,8 +583,7 @@ final class BuildRunner extends Runner {
     bool success = false;
     try {
       final String ninjaPath = p.join(
-        engineSrcDir.path,
-        'flutter',
+        engineSrcDir.parent.parent.path,
         'third_party',
         'ninja',
         'ninja',

engine/src/flutter/tools/pkg/engine_build_configs/test/build_config_runner_test.dart

@@ -116,7 +116,8 @@ void main() {
     // Check that the events for the Ninja command are correct.
     expect(events[2] is RunnerStart, isTrue);
     expect(events[2].name, equals('$buildName: ninja'));
-    expect(events[2].command[0], contains('ninja'));
+    final String rootPath = path.dirname(path.dirname(engine.srcDir.path));
+    expect(events[2].command[0], equals('$rootPath/third_party/ninja/ninja'));
     final String configPath = '${engine.srcDir.path}/out/${targetBuild.ninja.config}';
     expect(events[2].command.contains(configPath), isTrue);
     for (final String target in targetBuild.ninja.targets) {

third_party/.gitignore

@@ -0,0 +1,9 @@
+# Ignore everything by default, as these come from gclient/DEPS.
+# We'll explicitly include the folders we want to track.
+/*
+
+# Include the .gitignore file itself.
+!.gitignore
+
+# Allow custom README.flutter files in each folder.
+**/README.flutter