Skip to content

Commit 158a9a8

Browse files
fixes some gesture not getting disposed (#147112)
1 parent 2867575 commit 158a9a8

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

packages/flutter/test/gestures/recognizer_test.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,13 @@ void main() {
8787
testGesture('cleans up state after winning arena', (GestureTester tester) {
8888
final List<String> resolutions = <String>[];
8989
final IndefiniteGestureRecognizer indefinite = IndefiniteGestureRecognizer();
90+
addTearDown(indefinite.dispose);
9091
final TestPrimaryPointerGestureRecognizer<PointerUpEvent> accepting = TestPrimaryPointerGestureRecognizer<PointerUpEvent>(
9192
GestureDisposition.accepted,
9293
onAcceptGesture: () => resolutions.add('accepted'),
9394
onRejectGesture: () => resolutions.add('rejected'),
9495
);
96+
addTearDown(accepting.dispose);
9597
expect(accepting.state, GestureRecognizerState.ready);
9698
expect(accepting.primaryPointer, isNull);
9799
expect(accepting.initialPosition, isNull);
@@ -118,11 +120,13 @@ void main() {
118120
testGesture('cleans up state after losing arena', (GestureTester tester) {
119121
final List<String> resolutions = <String>[];
120122
final IndefiniteGestureRecognizer indefinite = IndefiniteGestureRecognizer();
123+
addTearDown(indefinite.dispose);
121124
final TestPrimaryPointerGestureRecognizer<PointerMoveEvent> rejecting = TestPrimaryPointerGestureRecognizer<PointerMoveEvent>(
122125
GestureDisposition.rejected,
123126
onAcceptGesture: () => resolutions.add('accepted'),
124127
onRejectGesture: () => resolutions.add('rejected'),
125128
);
129+
addTearDown(rejecting.dispose);
126130
expect(rejecting.state, GestureRecognizerState.ready);
127131
expect(rejecting.primaryPointer, isNull);
128132
expect(rejecting.initialPosition, isNull);
@@ -156,13 +160,15 @@ void main() {
156160
testGesture('works properly when recycled', (GestureTester tester) {
157161
final List<String> resolutions = <String>[];
158162
final IndefiniteGestureRecognizer indefinite = IndefiniteGestureRecognizer();
163+
addTearDown(indefinite.dispose);
159164
final TestPrimaryPointerGestureRecognizer<PointerUpEvent> accepting = TestPrimaryPointerGestureRecognizer<PointerUpEvent>(
160165
GestureDisposition.accepted,
161166
preAcceptSlopTolerance: 15,
162167
postAcceptSlopTolerance: 1000,
163168
onAcceptGesture: () => resolutions.add('accepted'),
164169
onRejectGesture: () => resolutions.add('rejected'),
165170
);
171+
addTearDown(accepting.dispose);
166172

167173
// Send one complete pointer sequence
168174
indefinite.addPointer(down);

packages/flutter/test/gestures/serial_tap_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ void main() {
190190
..onRelease = () {
191191
recognizedRelease = true;
192192
};
193+
addTearDown(release.dispose);
193194

194195
release.addPointer(down1);
195196
serial.addPointer(down1);
@@ -207,6 +208,7 @@ void main() {
207208
..onRelease = () {
208209
recognizedRelease = true;
209210
};
211+
addTearDown(release.dispose);
210212

211213
serial.addPointer(down1);
212214
release.addPointer(down1);
@@ -220,6 +222,7 @@ void main() {
220222

221223
testGesture('Fires cancel if competing recognizer declares victory', (GestureTester tester) {
222224
final WinningGestureRecognizer winner = WinningGestureRecognizer();
225+
addTearDown(winner.dispose);
223226
winner.addPointer(down1);
224227
serial.addPointer(down1);
225228
tester.closeArena(1);

0 commit comments

Comments
 (0)