Skip to content

Commit 152cbfc

Browse files
authored
Remove impeller-cmake build rules (#171407)
We no longer have any stakeholders relying on the impeller-cmake build, and I am no longer maintaining it. Developers who wish to use the Impeller renderer in native applications should consider using the awesome [Impeller Standalone C SDK](https://github.com/flutter/flutter/tree/master/engine/src/flutter/impeller/toolkit/interop#impeller-standalone-sdk) built by @chinmaygarde instead.
1 parent 2c970cc commit 152cbfc

File tree

3 files changed

+0
-205
lines changed

3 files changed

+0
-205
lines changed

DEPS

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,6 @@ vars = {
130130
# RBE will be downloaded from CIPD. This option is only usable by Googlers.
131131
'use_rbe': False,
132132

133-
# This is not downloaded be default because it increases the
134-
# `gclient sync` time by between 1 and 3 minutes. This option is enabled
135-
# in flutter/ci/builders/mac_impeller_cmake_example.json, and is likely to
136-
# only be useful locally when reproducing issues found by the bot.
137-
'download_impeller_cmake_example': False,
138-
139133
# Upstream URLs for third party dependencies, used in
140134
# determining common ancestor commit for vulnerability scanning
141135
# prefixed with 'upstream_' in order to be identified by parsing tool.
@@ -845,23 +839,6 @@ deps = {
845839
'dep_type': 'cipd',
846840
},
847841

848-
'engine/src/flutter/third_party/impeller-cmake-example': {
849-
'url': Var('flutter_git') + '/third_party/impeller-cmake-example.git' + '@' + '9f8298ec31dcbebbf019bd487888166abf2f55e6',
850-
'condition': 'download_impeller_cmake_example',
851-
},
852-
853-
# cmake is only used by impeller-cmake-example.
854-
'engine/src/flutter/buildtools/mac-x64/cmake': {
855-
'packages': [
856-
{
857-
'package': 'infra/3pp/tools/cmake/mac-amd64',
858-
'version': 'CGpMvZoP962wdEINR9d4OEvEW7ZOv0MPrHNKbBUBS0sC',
859-
}
860-
],
861-
'condition': 'download_impeller_cmake_example and host_os == "mac"',
862-
'dep_type': 'cipd',
863-
},
864-
865842
'engine/src/flutter/third_party/google_fonts_for_unit_tests': {
866843
'packages': [
867844
{
@@ -965,18 +942,6 @@ hooks = [
965942
'engine/src/flutter/tools/githooks/setup.py',
966943
]
967944
},
968-
{
969-
'name': 'impeller-cmake-example submodules',
970-
'pattern': '.',
971-
'condition': 'download_impeller_cmake_example',
972-
'action': [
973-
'python3',
974-
'engine/src/flutter/ci/impeller_cmake_build_test.py',
975-
'--path',
976-
'flutter/third_party/impeller-cmake-example',
977-
'--setup',
978-
]
979-
},
980945
{
981946
'name': 'Download Fuchsia system images',
982947
'pattern': '.',

engine/src/flutter/ci/impeller_cmake_build_test.py

Lines changed: 0 additions & 138 deletions
This file was deleted.

engine/src/flutter/tools/gn

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -865,28 +865,6 @@ def to_gn_wasm_args(args, gn_args):
865865
gn_args['flutter_prebuilt_dart_sdk'] = True
866866

867867

868-
def run_impeller_cmake(args):
869-
impeller_cmake_dir = os.path.join('flutter', 'third_party', 'impeller-cmake-example')
870-
if not os.path.isdir(os.path.join(SRC_ROOT, impeller_cmake_dir)):
871-
print('The Impeller cmake example directory "{}" does not exist'.format(impeller_cmake_dir))
872-
return 1
873-
cmake_cmd = [
874-
'python3',
875-
os.path.join(SRC_ROOT, 'flutter', 'ci', 'impeller_cmake_build_test.py'),
876-
'--path',
877-
impeller_cmake_dir,
878-
'--cmake',
879-
]
880-
if args.xcode_symlinks:
881-
cmake_cmd = cmake_cmd + ['--xcode-symlinks']
882-
try:
883-
cmake_call_result = subprocess.call(cmake_cmd, cwd=SRC_ROOT)
884-
except subprocess.CalledProcessError as exc:
885-
print('Failed to generate cmake files: ', exc.returncode, exc.output)
886-
return 1
887-
return cmake_call_result
888-
889-
890868
def parse_args(args):
891869
args = args[1:]
892870
parser = argparse.ArgumentParser(description='A script to run `gn gen`.')
@@ -1198,13 +1176,6 @@ def parse_args(args):
11981176

11991177
parser.add_argument('--malioc-path', type=str, help='The path to the malioc tool.')
12001178

1201-
parser.add_argument(
1202-
'--impeller-cmake-example',
1203-
default=False,
1204-
action='store_true',
1205-
help='Do not run GN. Instead configure the Impeller cmake example build.',
1206-
)
1207-
12081179
parser.add_argument(
12091180
'--slimpeller',
12101181
default=False,
@@ -1274,9 +1245,6 @@ def main(argv):
12741245
args = parse_args(argv)
12751246
validate_args(args)
12761247

1277-
if args.impeller_cmake_example:
1278-
return run_impeller_cmake(args)
1279-
12801248
exe = '.exe' if sys.platform.startswith(('cygwin', 'win')) else ''
12811249

12821250
command = [

0 commit comments

Comments
 (0)