Skip to content

Commit 12de94d

Browse files
authored
Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (#137837)
Fixes #136163
1 parent aa82e22 commit 12de94d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

packages/flutter_tools/lib/src/flutter_manifest.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ void _validateDeferredComponents(MapEntry<Object?, Object?> kvp, List<String> er
642642
if (valueMap.containsKey('assets')) {
643643
final Object? assets = valueMap['assets'];
644644
if (assets is! YamlList) {
645-
errors.add('Expected "assets" key in the $i element of "${kvp.key}" to be a list, but got $assets (${assets.runtimeType}).');
645+
errors.add('Expected "assets" to be a list, but got $assets (${assets.runtimeType}).');
646646
} else {
647647
_validateListType<String>(assets, errors, '"assets" key in the $i element of "${kvp.key}"', 'file paths');
648648
}

packages/flutter_tools/test/general.shard/flutter_manifest_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1459,7 +1459,7 @@ flutter:
14591459
);
14601460

14611461
expect(flutterManifest, null);
1462-
expect(logger.errorText, 'Expected "assets" key in the 0 element of "deferred-components" to be a list, but got blah (String).\n');
1462+
expect(logger.errorText, 'Expected "assets" to be a list, but got blah (String).\n');
14631463
});
14641464

14651465
testWithoutContext('FlutterManifest parses asset-only deferred components', () async {

0 commit comments

Comments
 (0)