Skip to content

Commit 1068d31

Browse files
authored
Fix and remove a few no-shuffle tags in flutter_tools. (#157656)
Two of the tests, `test_test` and `break_on_framework_exceptions`, no longer appear to leak (without changes). Perhaps underlying infrastructure has changed, or some other bug in the tool itself was fixed in meantime. `packages_test` required resetting `Cache.flutterRoot`. Work towards flutter/flutter#85160.
1 parent 42132e8 commit 1068d31

3 files changed

Lines changed: 7 additions & 22 deletions

File tree

packages/flutter_tools/test/commands.shard/permeable/packages_test.dart

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
// TODO(gspencergoog): Remove this tag once this test's state leaks/test
6-
// dependencies have been fixed.
7-
// https://github.com/flutter/flutter/issues/85160
8-
// Fails with "flutter test --test-randomize-ordering-seed=1000"
9-
@Tags(<String>['no-shuffle'])
10-
library;
11-
125
import 'dart:async';
136
import 'dart:convert';
147

@@ -38,9 +31,15 @@ void main() {
3831

3932
setUp(() {
4033
mockStdio = FakeStdio()..stdout.terminalColumns = 80;
34+
35+
// Some tests below override this with a blank root, always reset it.
36+
Cache.flutterRoot = null;
37+
});
38+
39+
setUpAll(() {
40+
Cache.disableLocking();
4141
});
4242

43-
Cache.disableLocking();
4443
group('packages get/upgrade', () {
4544
late Directory tempDir;
4645
late FakeAnalytics fakeAnalytics;

packages/flutter_tools/test/integration.shard/break_on_framework_exceptions_test.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
// TODO(gspencergoog): Remove this tag once this test's state leaks/test
6-
// dependencies have been fixed.
7-
// https://github.com/flutter/flutter/issues/85160
8-
// Fails with "flutter test --test-randomize-ordering-seed=1000"
9-
@Tags(<String>['no-shuffle'])
10-
library;
11-
125
import 'dart:async';
136

147
import 'package:file/file.dart';

packages/flutter_tools/test/integration.shard/test_test.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
// TODO(gspencergoog): Remove this tag once this test's state leaks/test
6-
// dependencies have been fixed.
7-
// https://github.com/flutter/flutter/issues/85160
8-
// Fails with "flutter test --test-randomize-ordering-seed=1000"
9-
@Tags(<String>['no-shuffle'])
10-
library;
11-
125
import 'dart:async';
136
import 'dart:convert';
147

0 commit comments

Comments
 (0)