Fix or except leaks. (#141081)

Contributes to flutter/devtools#6909.

Author: polina-c

packages/flutter/test/animation/live_binding_test.dart

@@ -9,6 +9,7 @@ library;
 
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
 
 void main() {
   /*
@@ -77,7 +78,10 @@ void main() {
     // Currently skipped due to daily flake: https://github.com/flutter/flutter/issues/87588
   }, skip: true); // Typically skip: isBrowser https://github.com/flutter/flutter/issues/42767
 
-  testWidgets('Should show event indicator for pointer events with setSurfaceSize', (WidgetTester tester) async {
+  testWidgets('Should show event indicator for pointer events with setSurfaceSize',
+  // TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787
+experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
+  (WidgetTester tester) async {
     final AnimationSheetBuilder animationSheet = AnimationSheetBuilder(frameSize: const Size(200, 200), allLayers: true);
     addTearDown(animationSheet.dispose);
     final List<Offset> taps = <Offset>[];

packages/flutter/test/cupertino/refresh_test.dart

@@ -10,6 +10,7 @@ import 'package:flutter/cupertino.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
 
 void main() {
   late FakeBuilder mockHelper;
@@ -34,7 +35,10 @@ void main() {
   }
 
   void uiTestGroup() {
-    testWidgets("doesn't invoke anything without user interaction", (WidgetTester tester) async {
+    testWidgets("doesn't invoke anything without user interaction",
+    // TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787
+    experimentalLeakTesting: LeakTesting.settings.withIgnoredAll(),
+    (WidgetTester tester) async {
       await tester.pumpWidget(
         CupertinoApp(
           home: CustomScrollView(

packages/flutter/test/cupertino/text_field_test.dart

@@ -10100,6 +10100,7 @@ void main() {
     final TextEditingController controller = TextEditingController(
       text: 'abcd',
     );
+    addTearDown(controller.dispose);
     await tester.pumpWidget(
       MaterialApp(
         home: Scaffold(

packages/flutter/test/cupertino/text_selection_toolbar_test.dart

@@ -343,6 +343,7 @@ void main() {
     final TextEditingController controller = TextEditingController(
       text: 'Select me custom menu',
     );
+    addTearDown(controller.dispose);
     await tester.pumpWidget(
       CupertinoApp(
         home: Center(

packages/flutter/test/flutter_test_config.dart

@@ -43,14 +43,8 @@ Future<void> testExecutable(FutureOr<void> Function() testMain) {
 
     LeakTesting.settings = LeakTesting
       .settings
-      .withTrackedAll()
-      // TODO(polina-c): clean up leaks and stop ignoring them.
-      // https://github.com/flutter/flutter/issues/137311
       .withIgnored(
         allNotGCed: true,
-        notDisposed: <String, int?>{
-          'OverlayEntry': null,
-        },
       );
   }
 

packages/flutter/test/foundation/memory_allocations_test.dart

@@ -6,6 +6,7 @@ import 'dart:ui';
 
 import 'package:flutter/foundation.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
 
 class PrintOverrideTestBinding extends AutomatedTestWidgetsFlutterBinding {
   @override
@@ -26,6 +27,9 @@ class PrintOverrideTestBinding extends AutomatedTestWidgetsFlutterBinding {
 }
 
 void main() {
+  // LeakTesting is turned off because it adds subscriptions to
+  // [FlutterMemoryAllocations], that may interfere with the tests.
+  LeakTesting.settings = LeakTesting.settings.withIgnoredAll();
   final FlutterMemoryAllocations ma = FlutterMemoryAllocations.instance;
 
   PrintOverrideTestBinding();

packages/flutter/test/gestures/drag_test.dart

@@ -81,8 +81,8 @@ void main() {
     final HorizontalDragGestureRecognizer drag = HorizontalDragGestureRecognizer();
     final VerticalDragGestureRecognizer competingDrag = VerticalDragGestureRecognizer()
       ..onStart = (_) {};
-    addTearDown(() => drag.dispose);
-    addTearDown(() => competingDrag.dispose);
+    addTearDown(drag.dispose);
+    addTearDown(competingDrag.dispose);
 
     late Offset positionAtOnStart;
     drag.onStart = (DragStartDetails details) {
@@ -104,8 +104,8 @@ void main() {
     final HorizontalDragGestureRecognizer drag = HorizontalDragGestureRecognizer();
     final VerticalDragGestureRecognizer competingDrag = VerticalDragGestureRecognizer()
       ..onStart = (_) {};
-    addTearDown(() => drag.dispose);
-    addTearDown(() => competingDrag.dispose);
+    addTearDown(drag.dispose);
+    addTearDown(competingDrag.dispose);
 
     Offset? positionAtOnStart;
     drag.onStart = (DragStartDetails details) {
@@ -354,7 +354,7 @@ void main() {
 
     final VerticalDragGestureRecognizer competingDrag = VerticalDragGestureRecognizer()
       ..onStart = (_) {};
-    addTearDown(() => competingDrag.dispose);
+    addTearDown(competingDrag.dispose);
 
     down = pointer.down(const Offset(10.0, 10.0), timeStamp: const Duration(milliseconds: 600));
     drag.addPointer(down);
@@ -436,8 +436,8 @@ void main() {
     final VerticalDragGestureRecognizer competingDrag = VerticalDragGestureRecognizer()
       ..dragStartBehavior = DragStartBehavior.down
       ..onStart = (_) {};
-    addTearDown(() => drag.dispose);
-    addTearDown(() => competingDrag.dispose);
+    addTearDown(drag.dispose);
+    addTearDown(competingDrag.dispose);
 
     Offset? positionAtOnStart;
     drag.onStart = (DragStartDetails details) {
@@ -475,8 +475,8 @@ void main() {
       VerticalDragGestureRecognizer()
         ..dragStartBehavior = DragStartBehavior.down
         ..multitouchDragStrategy = MultitouchDragStrategy.sumAllPointers;
-    addTearDown(() => drag1.dispose);
-    addTearDown(() => drag2.dispose);
+    addTearDown(drag1.dispose);
+    addTearDown(drag2.dispose);
 
     final List<String> log = <String>[];
     drag1.onDown = (_) { log.add('drag1-down'); };
@@ -556,8 +556,8 @@ void main() {
     HorizontalDragGestureRecognizer() ..dragStartBehavior = DragStartBehavior.down;
     final VerticalDragGestureRecognizer drag2 =
     VerticalDragGestureRecognizer() ..dragStartBehavior = DragStartBehavior.down;
-    addTearDown(() => drag1.dispose);
-    addTearDown(() => drag2.dispose);
+    addTearDown(drag1.dispose);
+    addTearDown(drag2.dispose);
 
     final List<String> log = <String>[];
     drag1.onDown = (_) { log.add('drag1-down'); };

packages/flutter/test/gestures/force_press_test.dart

@@ -30,6 +30,7 @@ void main() {
     }
 
     final ForcePressGestureRecognizer force = ForcePressGestureRecognizer();
+    addTearDown(force.dispose);
 
     force.onStart = onStart;
     force.onPeak = (ForcePressDetails details) => peaked += 1;
@@ -113,6 +114,7 @@ void main() {
       int ended = 0;
 
       final ForcePressGestureRecognizer force = ForcePressGestureRecognizer();
+      addTearDown(force.dispose);
 
       force.onStart = (ForcePressDetails details) => started += 1;
       force.onPeak = (ForcePressDetails details) => peaked += 1;
@@ -167,6 +169,7 @@ void main() {
     int ended = 0;
 
     final ForcePressGestureRecognizer force = ForcePressGestureRecognizer();
+    addTearDown(force.dispose);
 
     force.onStart = (_) => started += 1;
     force.onPeak = (_) => peaked += 1;
@@ -204,6 +207,7 @@ void main() {
 
   testGesture('Should recognize drag and not force touch if there is a drag recognizer', (GestureTester tester) {
     final PanGestureRecognizer drag = PanGestureRecognizer();
+    addTearDown(drag.dispose);
 
     // Device specific constants that represent those from the iPhone X
     const double pressureMin = 0;
@@ -215,6 +219,7 @@ void main() {
     int ended = 0;
 
     final ForcePressGestureRecognizer force = ForcePressGestureRecognizer();
+    addTearDown(force.dispose);
 
     force.onStart = (_) => started += 1;
     force.onPeak = (_) => peaked += 1;
@@ -276,6 +281,7 @@ void main() {
 
   testGesture('Should not call ended on pointer up if the gesture was never accepted', (GestureTester tester) {
     final PanGestureRecognizer drag = PanGestureRecognizer();
+    addTearDown(drag.dispose);
 
     // Device specific constants that represent those from the iPhone X
     const double pressureMin = 0;
@@ -287,6 +293,7 @@ void main() {
     int ended = 0;
 
     final ForcePressGestureRecognizer force = ForcePressGestureRecognizer();
+    addTearDown(force.dispose);
 
     force.onStart = (_) => started += 1;
     force.onPeak = (_) => peaked += 1;
@@ -321,6 +328,7 @@ void main() {
 
   testGesture('Should call start only once if there is a competing gesture recognizer', (GestureTester tester) {
     final PanGestureRecognizer drag = PanGestureRecognizer();
+    addTearDown(drag.dispose);
 
     // Device specific constants that represent those from the iPhone X
     const double pressureMin = 0;
@@ -332,6 +340,7 @@ void main() {
     int ended = 0;
 
     final ForcePressGestureRecognizer force = ForcePressGestureRecognizer();
+    addTearDown(force.dispose);
 
     force.onStart = (_) => started += 1;
     force.onPeak = (_) => peaked += 1;
@@ -398,6 +407,7 @@ void main() {
     }
 
     final ForcePressGestureRecognizer force = ForcePressGestureRecognizer(interpolation: interpolateWithEasing);
+    addTearDown(force.dispose);
 
     force.onStart = onStart;
     force.onPeak = (ForcePressDetails details) => peaked += 1;
@@ -488,6 +498,7 @@ void main() {
     int ended = 0;
 
     final ForcePressGestureRecognizer force = ForcePressGestureRecognizer();
+    addTearDown(force.dispose);
 
     force.onStart = (_) => started += 1;
     force.onPeak = (_) => peaked += 1;
@@ -536,6 +547,7 @@ void main() {
     int ended = 0;
 
     final ForcePressGestureRecognizer force = ForcePressGestureRecognizer();
+    addTearDown(force.dispose);
 
     force.onStart = (_) => started += 1;
     force.onPeak = (_) => peaked += 1;

packages/flutter/test/gestures/monodrag_test.dart

@@ -40,8 +40,10 @@ void main() {
 
     final VerticalDragGestureRecognizer v = VerticalDragGestureRecognizer()
       ..onStart = (_) { };
+    addTearDown(v.dispose);
     final HorizontalDragGestureRecognizer h = HorizontalDragGestureRecognizer()
       ..onStart = (_) { };
+    addTearDown(h.dispose);
 
     const PointerDownEvent down90 = PointerDownEvent(
       pointer: 90,

packages/flutter/test/gestures/scale_test.dart

@@ -633,6 +633,7 @@ void main() {
   // Regressing test for https://github.com/flutter/flutter/issues/78941
   testGesture('First rotation test', (GestureTester tester) {
     final ScaleGestureRecognizer scale = ScaleGestureRecognizer();
+    addTearDown(scale.dispose);
 
     double? updatedRotation;
     scale.onUpdate = (ScaleUpdateDetails details) {
@@ -712,7 +713,9 @@ void main() {
 
   testGesture('Should recognize scale gestures from pointer pan/zoom events', (GestureTester tester) {
     final ScaleGestureRecognizer scale = ScaleGestureRecognizer();
+    addTearDown(scale.dispose);
     final HorizontalDragGestureRecognizer drag = HorizontalDragGestureRecognizer();
+    addTearDown(drag.dispose);
 
     bool didStartScale = false;
     Offset? updatedFocalPoint;
@@ -812,7 +815,9 @@ void main() {
 
   testGesture('Pointer pan/zooms should work alongside touches', (GestureTester tester) {
     final ScaleGestureRecognizer scale = ScaleGestureRecognizer();
+    addTearDown(scale.dispose);
     final HorizontalDragGestureRecognizer drag = HorizontalDragGestureRecognizer();
+    addTearDown(drag.dispose);
 
     bool didStartScale = false;
     Offset? updatedFocalPoint;
@@ -1062,7 +1067,9 @@ void main() {
 
   testGesture('Scale gesture from pan/zoom events properly handles DragStartBehavior.start', (GestureTester tester) {
     final ScaleGestureRecognizer scale = ScaleGestureRecognizer(dragStartBehavior: DragStartBehavior.start);
+    addTearDown(scale.dispose);
     final HorizontalDragGestureRecognizer drag = HorizontalDragGestureRecognizer();
+    addTearDown(drag.dispose);
 
     bool didStartScale = false;
     Offset? updatedFocalPoint;
@@ -1161,8 +1168,6 @@ void main() {
     expect(updatedDelta, isNull);
     expect(didEndScale, isTrue);
     didEndScale = false;
-
-    scale.dispose();
   });
 
   testGesture('scale trackpadScrollCausesScale', (GestureTester tester) {