[Impeller] re-enable Adreno 630 (#161287)

Part of flutter/flutter#161209

Author: Jonah Williams

engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc

@@ -331,16 +331,10 @@ bool DriverInfoVK::IsEmulator() const {
 bool DriverInfoVK::IsKnownBadDriver() const {
   if (adreno_gpu_.has_value()) {
     AdrenoGPU adreno = adreno_gpu_.value();
-    // See:
-    // https://github.com/flutter/flutter/issues/154103
-    //
-    // Reports "VK_INCOMPLETE" when compiling certain entity shader with
-    // vkCreateGraphicsPipelines, which is not a valid return status.
-    // See https://github.com/flutter/flutter/issues/155185 .
-    //
-    // https://github.com/flutter/flutter/issues/155185
-    // Unknown crashes but device is not easily acquirable.
-    if (adreno <= AdrenoGPU::kAdreno630) {
+    // 630 is the lowest version I've tested on the still works.
+    // I suspect earlier 600s should work but this is waiting on
+    // more devices for testing.
+    if (adreno < AdrenoGPU::kAdreno630) {
       return true;
     }
   }

engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk_unittests.cc

@@ -163,7 +163,6 @@ TEST(DriverInfoVKTest, DriverParsingAdreno) {
 }
 
 TEST(DriverInfoVKTest, DisabledDevices) {
-  EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 630"));
   EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 620"));
   EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 610"));
   EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 530"));
@@ -174,6 +173,7 @@ TEST(DriverInfoVKTest, DisabledDevices) {
   EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 505"));
   EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 504"));
 
+  EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 630"));
   EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 640"));
   EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 650"));
 }