Skip to content

Commit d678f65

Browse files
authored
Missed linter argument comment violations (flutter#47310)
## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 065ef7c commit d678f65

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

impeller/display_list/dl_unittests.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1390,7 +1390,7 @@ TEST_P(DisplayListTest, DrawVerticesSolidColorTrianglesWithoutIndices) {
13901390

13911391
auto vertices = flutter::DlVertices::Make(
13921392
flutter::DlVertexMode::kTriangles, 3, positions.data(),
1393-
/*texture_coorindates=*/nullptr, colors.data());
1393+
/*texture_coordinates=*/nullptr, colors.data());
13941394

13951395
flutter::DisplayListBuilder builder;
13961396
flutter::DlPaint paint;
@@ -1409,7 +1409,7 @@ TEST_P(DisplayListTest, DrawVerticesLinearGradientWithoutIndices) {
14091409

14101410
auto vertices = flutter::DlVertices::Make(
14111411
flutter::DlVertexMode::kTriangles, 3, positions.data(),
1412-
/*texture_coorindates=*/nullptr, /*colors=*/nullptr);
1412+
/*texture_coordinates=*/nullptr, /*colors=*/nullptr);
14131413

14141414
std::vector<flutter::DlColor> colors = {flutter::DlColor::kBlue(),
14151415
flutter::DlColor::kRed()};
@@ -1519,7 +1519,7 @@ TEST_P(DisplayListTest, DrawVerticesSolidColorTrianglesWithIndices) {
15191519

15201520
auto vertices = flutter::DlVertices::Make(
15211521
flutter::DlVertexMode::kTriangles, 6, positions.data(),
1522-
/*texture_coorindates=*/nullptr, /*colors=*/nullptr, 6, indices.data());
1522+
/*texture_coordinates=*/nullptr, /*colors=*/nullptr, 6, indices.data());
15231523

15241524
flutter::DisplayListBuilder builder;
15251525
flutter::DlPaint paint;
@@ -1540,7 +1540,7 @@ TEST_P(DisplayListTest, DrawVerticesPremultipliesColors) {
15401540

15411541
auto vertices = flutter::DlVertices::Make(
15421542
flutter::DlVertexMode::kTriangles, 6, positions.data(),
1543-
/*texture_coorindates=*/nullptr, colors.data(), 6, indices.data());
1543+
/*texture_coordinates=*/nullptr, colors.data(), 6, indices.data());
15441544

15451545
flutter::DisplayListBuilder builder;
15461546
flutter::DlPaint paint;
@@ -1668,7 +1668,7 @@ TEST_P(DisplayListTest, DrawVerticesBlendModes) {
16681668

16691669
auto vertices = flutter::DlVertices::Make(
16701670
flutter::DlVertexMode::kTriangles, 3, positions.data(),
1671-
/*texture_coorindates=*/nullptr, colors.data());
1671+
/*texture_coordinates=*/nullptr, colors.data());
16721672

16731673
flutter::DisplayListBuilder builder;
16741674
flutter::DlPaint paint;

shell/platform/android/external_view_embedder/external_view_embedder.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ void AndroidExternalViewEmbedder::SubmitFrame(
7979

8080
// Restore the clip context after exiting this method since it's changed
8181
// below.
82-
DlAutoCanvasRestore save(background_canvas, /*doSave=*/true);
82+
DlAutoCanvasRestore save(background_canvas, /*do_save=*/true);
8383

8484
for (size_t i = 0; i < current_frame_view_count; i++) {
8585
int64_t view_id = composition_order_[i];

0 commit comments

Comments
 (0)