Skip to content

Commit 96898c4

Browse files
authored
Remove "gclient sync" warning call during pre-rebase (flutter#52342)
Remove `pre-rebase` check from `gclient sync` warning, and instead remove the warning call from `pre_rebase_command` Follow-up to flutter/engine#52133 (comment)
1 parent 66c4f0f commit 96898c4

2 files changed

Lines changed: 0 additions & 6 deletions

File tree

tools/githooks/lib/src/messages.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ const String _reset = '\x1B[0m';
1010
/// Prints a reminder to stdout to run `gclient sync -D`. Uses colors when
1111
/// stdout supports ANSI escape codes.
1212
void printGclientSyncReminder(String command) {
13-
if (command == 'pre-rebase') {
14-
return;
15-
}
1613
final String prefix = io.stdout.supportsAnsiEscapes ? _redBoldUnderline : '';
1714
final String postfix = io.stdout.supportsAnsiEscapes ? _reset : '';
1815
io.stderr.writeln('$command: The engine source tree has been updated.');

tools/githooks/lib/src/pre_rebase_command.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
import 'package:args/command_runner.dart';
66

7-
import 'messages.dart';
8-
97
/// The command that implements the pre-rebase githook
108
class PreRebaseCommand extends Command<bool> {
119
@override
@@ -16,7 +14,6 @@ class PreRebaseCommand extends Command<bool> {
1614

1715
@override
1816
Future<bool> run() async {
19-
printGclientSyncReminder(name);
2017
// Returning false here will block the rebase.
2118
return true;
2219
}

0 commit comments

Comments
 (0)