[Impeller] Remove GPUTracer. (flutter#41079)

chinmaygarde · web-flow · commit 290de92a9bc6 · 2023-04-11T17:07:16.000Z
[Impeller] Remove GPUTracer.
diff --git a/ci/licenses_golden/licenses_flutter b/ci/licenses_golden/licenses_flutter
@@ -1442,8 +1442,6 @@ ORIGIN: ../../../flutter/impeller/renderer/backend/metal/device_buffer_mtl.h + .
 ORIGIN: ../../../flutter/impeller/renderer/backend/metal/device_buffer_mtl.mm + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/backend/metal/formats_mtl.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/backend/metal/formats_mtl.mm + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/renderer/backend/metal/gpu_tracer_mtl.h + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/renderer/backend/metal/gpu_tracer_mtl.mm + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/backend/metal/pipeline_library_mtl.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/backend/metal/pipeline_library_mtl.mm + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/backend/metal/pipeline_mtl.h + ../../../flutter/LICENSE
@@ -1547,8 +1545,6 @@ ORIGIN: ../../../flutter/impeller/renderer/compute_tessellator.cc + ../../../flu
 ORIGIN: ../../../flutter/impeller/renderer/compute_tessellator.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/context.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/context.h + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/renderer/gpu_tracer.cc + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/renderer/gpu_tracer.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/path_polyline.comp + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/pipeline.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/pipeline.h + ../../../flutter/LICENSE
@@ -4030,8 +4026,6 @@ FILE: ../../../flutter/impeller/renderer/backend/metal/device_buffer_mtl.h
 FILE: ../../../flutter/impeller/renderer/backend/metal/device_buffer_mtl.mm
 FILE: ../../../flutter/impeller/renderer/backend/metal/formats_mtl.h
 FILE: ../../../flutter/impeller/renderer/backend/metal/formats_mtl.mm
-FILE: ../../../flutter/impeller/renderer/backend/metal/gpu_tracer_mtl.h
-FILE: ../../../flutter/impeller/renderer/backend/metal/gpu_tracer_mtl.mm
 FILE: ../../../flutter/impeller/renderer/backend/metal/pipeline_library_mtl.h
 FILE: ../../../flutter/impeller/renderer/backend/metal/pipeline_library_mtl.mm
 FILE: ../../../flutter/impeller/renderer/backend/metal/pipeline_mtl.h
@@ -4135,8 +4129,6 @@ FILE: ../../../flutter/impeller/renderer/compute_tessellator.cc
 FILE: ../../../flutter/impeller/renderer/compute_tessellator.h
 FILE: ../../../flutter/impeller/renderer/context.cc
 FILE: ../../../flutter/impeller/renderer/context.h
-FILE: ../../../flutter/impeller/renderer/gpu_tracer.cc
-FILE: ../../../flutter/impeller/renderer/gpu_tracer.h
 FILE: ../../../flutter/impeller/renderer/path_polyline.comp
 FILE: ../../../flutter/impeller/renderer/pipeline.cc
 FILE: ../../../flutter/impeller/renderer/pipeline.h
diff --git a/impeller/renderer/BUILD.gn b/impeller/renderer/BUILD.gn
@@ -63,8 +63,6 @@ impeller_component("renderer") {
     "compute_pipeline_descriptor.h",
     "context.cc",
     "context.h",
-    "gpu_tracer.cc",
-    "gpu_tracer.h",
     "pipeline.cc",
     "pipeline.h",
     "pipeline_builder.cc",
diff --git a/impeller/renderer/backend/metal/BUILD.gn b/impeller/renderer/backend/metal/BUILD.gn
@@ -24,8 +24,6 @@ impeller_component("metal") {
     "device_buffer_mtl.mm",
     "formats_mtl.h",
     "formats_mtl.mm",
-    "gpu_tracer_mtl.h",
-    "gpu_tracer_mtl.mm",
     "pipeline_library_mtl.h",
     "pipeline_library_mtl.mm",
     "pipeline_mtl.h",
diff --git a/impeller/renderer/backend/metal/context_mtl.h b/impeller/renderer/backend/metal/context_mtl.h
@@ -14,7 +14,6 @@
 #include "impeller/core/sampler.h"
 #include "impeller/renderer/backend/metal/allocator_mtl.h"
 #include "impeller/renderer/backend/metal/command_buffer_mtl.h"
-#include "impeller/renderer/backend/metal/gpu_tracer_mtl.h"
 #include "impeller/renderer/backend/metal/pipeline_library_mtl.h"
 #include "impeller/renderer/backend/metal/shader_library_mtl.h"
 #include "impeller/renderer/capabilities.h"
@@ -55,9 +54,6 @@ class ContextMTL final : public Context,
   // |Context|
   std::shared_ptr<CommandBuffer> CreateCommandBuffer() const override;
 
-  // |Context|
-  std::shared_ptr<GPUTracer> GetGPUTracer() const override;
-
   // |Context|
   const std::shared_ptr<const Capabilities>& GetCapabilities() const override;
 
@@ -71,7 +67,6 @@ class ContextMTL final : public Context,
   std::shared_ptr<PipelineLibraryMTL> pipeline_library_;
   std::shared_ptr<SamplerLibrary> sampler_library_;
   std::shared_ptr<AllocatorMTL> resource_allocator_;
-  std::shared_ptr<GPUTracerMTL> gpu_tracer_;
   std::shared_ptr<const Capabilities> device_capabilities_;
   bool is_valid_ = false;
 
diff --git a/impeller/renderer/backend/metal/context_mtl.mm b/impeller/renderer/backend/metal/context_mtl.mm
@@ -120,12 +120,6 @@ static bool DeviceSupportsComputeSubgroups(id<MTLDevice> device) {
     }
   }
 
-#if (FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_DEBUG) || \
-    (FLUTTER_RUNTIME_MODE == FLUTTER_RUNTIME_MODE_PROFILE)
-  // Setup the gpu tracer.
-  { gpu_tracer_ = std::shared_ptr<GPUTracerMTL>(new GPUTracerMTL(device_)); }
-#endif
-
   device_capabilities_ =
       InferMetalCapabilities(device_, PixelFormat::kB8G8R8A8UNormInt);
 
@@ -255,10 +249,6 @@ static bool DeviceSupportsComputeSubgroups(id<MTLDevice> device) {
   return CreateCommandBufferInQueue(command_queue_);
 }
 
-std::shared_ptr<GPUTracer> ContextMTL::GetGPUTracer() const {
-  return gpu_tracer_;
-}
-
 std::shared_ptr<CommandBuffer> ContextMTL::CreateCommandBufferInQueue(
     id<MTLCommandQueue> queue) const {
   if (!IsValid()) {
diff --git a/impeller/renderer/backend/metal/gpu_tracer_mtl.h b/impeller/renderer/backend/metal/gpu_tracer_mtl.h
diff --git a/impeller/renderer/backend/metal/gpu_tracer_mtl.mm b/impeller/renderer/backend/metal/gpu_tracer_mtl.mm
diff --git a/impeller/renderer/context.cc b/impeller/renderer/context.cc
@@ -10,10 +10,6 @@ Context::~Context() = default;
 
 Context::Context() = default;
 
-std::shared_ptr<GPUTracer> Context::GetGPUTracer() const {
-  return nullptr;
-}
-
 bool Context::UpdateOffscreenLayerPixelFormat(PixelFormat format) {
   return false;
 }
diff --git a/impeller/renderer/context.h b/impeller/renderer/context.h
@@ -18,7 +18,6 @@ class SamplerLibrary;
 class CommandBuffer;
 class PipelineLibrary;
 class Allocator;
-class GPUTracer;
 
 class Context : public std::enable_shared_from_this<Context> {
  public:
@@ -41,8 +40,6 @@ class Context : public std::enable_shared_from_this<Context> {
 
   virtual std::shared_ptr<CommandBuffer> CreateCommandBuffer() const = 0;
 
-  virtual std::shared_ptr<GPUTracer> GetGPUTracer() const;
-
  protected:
   Context();
 
diff --git a/impeller/renderer/gpu_tracer.cc b/impeller/renderer/gpu_tracer.cc
diff --git a/impeller/renderer/gpu_tracer.h b/impeller/renderer/gpu_tracer.h
diff --git a/impeller/renderer/testing/mocks.h b/impeller/renderer/testing/mocks.h
@@ -97,8 +97,6 @@ class MockImpellerContext : public Context {
 
   MOCK_CONST_METHOD0(CreateCommandBuffer, std::shared_ptr<CommandBuffer>());
 
-  MOCK_CONST_METHOD0(GetGPUTracer, std::shared_ptr<GPUTracer>());
-
   MOCK_CONST_METHOD0(GetCapabilities,
                      const std::shared_ptr<const Capabilities>&());
 };

Original file line number	Diff line number	Diff line change
`@@ -10,10 +10,6 @@ Context::~Context() = default;`
`10`	`10`
`11`	`11`	`Context::Context() = default;`
`12`	`12`
`13`		`-std::shared_ptr<GPUTracer> Context::GetGPUTracer() const {`
`14`		`- return nullptr;`
`15`		`-}`
`16`		`-`
`17`	`13`	`bool Context::UpdateOffscreenLayerPixelFormat(PixelFormat format) {`
`18`	`14`	`return false;`
`19`	`15`	`}`