Add IME support for native #2046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
on Windows and chrome
|
emilk
reviewed
Sep 15, 2022
emilk
reviewed
Sep 15, 2022
emilk
requested changes
Sep 15, 2022
Owner
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Looks good, but I think input_method_editor_started is unused afaict?
Contributor
Author
|
Both input_method_editor_started and cranky warnings fixed. |
Owner
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IME support to native. Tested on Windows 10, MacOS 10.15.3 and chrome. Sorry for my poor English.
Closes #248.