Skip to content

Commit b3ee10a

Browse files
authored
Fixed configuration loading order to allow environment overwrites (#11)
1 parent 76233c1 commit b3ee10a

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

ES.Kubernetes.Reflector.CertManager/CertificatesMonitor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public async Task Handle(WatcherEvent<V1beta1CustomResourceDefinition> request,
103103
var resourceDefinition = request.Item;
104104

105105
_certificateResourceDefinitionVersion = request.Item.Spec.Version;
106-
_logger.LogInformation("Updating watchers for {kind} version {version}",
106+
_logger.LogDebug("Updating watchers for {kind} version {version}",
107107
CertManagerConstants.CertificateKind, request.Item.Spec.Version);
108108

109109
await _certificatesWatcher.Stop();

ES.Kubernetes.Reflector/Program.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ public static async Task<int> Main(string[] args)
1717
Log.Logger = new LoggerConfiguration()
1818
.ReadFrom.Configuration(new ConfigurationBuilder()
1919
.SetBasePath(Directory.GetCurrentDirectory())
20-
.AddCommandLine(args ?? new string[0])
21-
.AddEnvironmentVariables("ES_")
2220
.AddJsonFile("reflector.logging.json")
21+
.AddEnvironmentVariables("ES_")
22+
.AddCommandLine(args ?? new string[0])
2323
.Build())
2424
.CreateLogger();
2525

@@ -51,9 +51,9 @@ public static IWebHostBuilder CreateWebHostBuilder(string[] args)
5151
.ConfigureAppConfiguration((ctx, builder) =>
5252
{
5353
builder.SetBasePath(Directory.GetCurrentDirectory());
54-
builder.AddCommandLine(args ?? new string[0]);
55-
builder.AddEnvironmentVariables("ES_");
5654
builder.AddJsonFile("reflector.appsettings.json", false, true);
55+
builder.AddEnvironmentVariables("ES_");
56+
builder.AddCommandLine(args ?? new string[0]);
5757
})
5858
.ConfigureServices(services =>
5959
{

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Reflector can be deployed either manually or using Helm (recommended).
2525
Use Helm to install the latest released chart:
2626
```shellsession
2727
$ helm repo add emberstack https://emberstack.github.io/helm-charts
28-
$ helm update
28+
$ helm repo update
2929
$ helm upgrade --install reflector emberstack/reflector
3030
```
3131

0 commit comments

Comments
 (0)