Skip to content

Remove jupyter-server-terminal cap and fix release script #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Remove jupyter-server-terminal cap and fix release script #3057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2198350
Remove jupyter-server-terminal cap and fix release script
akchinSTC Dec 14, 2022
8557e70
Add comment regarding check failure
akchinSTC Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ install-gitlab-dependency:
- $(PYTHON_PIP) install --upgrade python-gitlab

check-install:
# Expected to fail due to elyra/ai#3058
jupyter server extension list
jupyter labextension list

Expand Down
2 changes: 1 addition & 1 deletion create-release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ def publish_release(working_dir) -> None:
f"{config.source_dir}/dist/elyra-{config.new_version}-py3-none-any.whl",
f"{config.source_dir}/dist/elyra-{config.new_version}.tar.gz",
f"{config.source_dir}/dist/elyra_server-{config.new_version}-py3-none-any.whl",
f"{config.source_dir}/dist/elyra-server-{config.new_version}.tar.gz",
f"{config.source_dir}/dist/elyra_server-{config.new_version}.tar.gz",
f"{config.work_dir}/airflow-notebook/dist/airflow_notebook-{config.new_version}-py3-none-any.whl",
f"{config.work_dir}/airflow-notebook/dist/airflow-notebook-{config.new_version}.tar.gz",
f"{config.work_dir}/kfp-notebook/dist/kfp_notebook-{config.new_version}-py3-none-any.whl",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ dependencies = [
"jupyter-events<0.5.0", # Cap from kfp from jsonschema
"jupyter-packaging>=0.10",
"jupyter_server>=1.7.0",
"jupyter_server_terminals<=0.4.0",
"jupyterlab>=3.4.6,<4.0", # comment out to use local jupyterlab
"jupyterlab-lsp>=3.8.0", # comment out to use local jupyterlab
"jupyterlab-git~=0.32", # Avoid breaking 1.x changes
Expand Down Expand Up @@ -183,6 +182,7 @@ exclude = [
".DS_Store",
"*.sh",
"docs",
"build/release",
]

# Move flake8 configuration from setup.cfg. Use pflake8 instead of flake8.
Expand Down