Faster filter #68
Merged
Faster filter #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the performance of the
filterfunction.The main change is that we don't call
Maybe.map f, which removes some wrapping and unwrapping of the value. With it, we are in practice doing 2 pattern matching (one in this function and one in Maybe.map), plus wrapping the value in aJustinside theMaybe.map.In this proposed version, these operations are removed compared to the original version.
Here is a benchmark: https://ellie-app.com/fCC677f4YLKa1
(Note and if you're interested: This is similar-ish to the PR I made for
Result.Extra.filterelm-community/result-extra#31 )