Skip to content

test(app): reject terminal loading frames in the aesthetic audit #17132

Description

@lalalune

Problem

The exact rebased audit:app run passed all 254 Playwright cases and classified every view good/needs-eyeball, but manual screenshot review found plugin-finances-gui at mobile-landscape captured as only Finances / Loading. The other three viewports contained the populated finance fixture.

The audit only waits for [data-view-status="loading"]. Domain views such as FinancesSpatialView render a visible Loading state without that lazy-bundle marker, so readable title/composer text satisfies readiness immediately and a pending frame receives a healthy verdict. Exact screenshot SHA-256 and report/OCR provenance are retained in the isolated audit bundle.

Acceptance criteria

  • Readiness recognizes visible domain loading states in addition to the lazy-bundle marker and waits for them to settle.
  • A domain loading state that does not settle within the bounded readiness window becomes a render-state failure and cannot receive a healthy verdict.
  • Regression tests prove visible exact/loading labels are detected, hidden/stale markers do not false-positive, and a settled populated state passes.
  • The full four-viewport audit is rerun; plugin-finances-gui is populated in all four screenshots and manually reviewed.
  • OCR expectations independently reject a terminal Loading capture so two different gates cover the failure.

Metadata

Metadata

Assignees

No one assigned

    Labels

    PluginbugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions