Skip to content

Commit 1f377f3

Browse files
committed
refactor: add missing not null constraints to letter-sound assessment
#2191
1 parent 1a6af77 commit 1f377f3

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

src/main/java/ai/elimu/entity/analytics/LetterSoundAssessmentEvent.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package ai.elimu.entity.analytics;
22

33
import jakarta.persistence.Entity;
4+
import jakarta.validation.constraints.NotNull;
45
import lombok.Getter;
56
import lombok.Setter;
67

@@ -12,11 +13,13 @@ public class LetterSoundAssessmentEvent extends AssessmentEvent {
1213
/**
1314
* The sequence of letters. E.g. <code>"sh"</code>.
1415
*/
16+
@NotNull
1517
private String letterSoundLetters;
1618

1719
/**
1820
* The sequence of sounds (IPA values). E.g. <code>"ʃ"</code>.
1921
*/
22+
@NotNull
2023
private String letterSoundSounds;
2124

2225
/**

src/main/java/ai/elimu/web/analytics/students/LetterSoundAssessmentEventsCsvExportController.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ public void handleRequest(
4747
"id",
4848
"timestamp",
4949
"package_name",
50-
"letter_sound_letters",
51-
"letter_sound_sounds",
52-
"letter_sound_id",
5350
"mastery_score",
5451
"time_spent_ms",
55-
"additional_data"
52+
"additional_data",
53+
"letter_sound_letters",
54+
"letter_sound_sounds",
55+
"letter_sound_id"
5656
)
5757
.build();
5858

@@ -66,12 +66,12 @@ public void handleRequest(
6666
letterSoundAssessmentEvent.getId(),
6767
letterSoundAssessmentEvent.getTimestamp().getTimeInMillis(),
6868
letterSoundAssessmentEvent.getPackageName(),
69-
letterSoundAssessmentEvent.getLetterSoundLetters(),
70-
letterSoundAssessmentEvent.getLetterSoundSounds(),
71-
letterSoundAssessmentEvent.getLetterSoundId(),
7269
letterSoundAssessmentEvent.getMasteryScore(),
7370
letterSoundAssessmentEvent.getTimeSpentMs(),
74-
letterSoundAssessmentEvent.getAdditionalData()
71+
letterSoundAssessmentEvent.getAdditionalData(),
72+
letterSoundAssessmentEvent.getLetterSoundLetters(),
73+
letterSoundAssessmentEvent.getLetterSoundSounds(),
74+
letterSoundAssessmentEvent.getLetterSoundId()
7575
);
7676
}
7777
csvPrinter.flush();
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# 2.6.47
2+
3+
ALTER TABLE `LetterSoundAssessmentEvent` MODIFY `letterSoundLetters` VARCHAR(255) NOT NULL;
4+
ALTER TABLE `LetterSoundAssessmentEvent` MODIFY `letterSoundSounds` VARCHAR(255) NOT NULL;

0 commit comments

Comments
 (0)