chore: fixup GN build file

* nodejs/node#55529
* nodejs/node#55798
* nodejs/node#55530

Author: codebytere

patches/node/build_add_gn_build_files.patch

@@ -21,27 +21,6 @@ index d6909b95886f4de3f0b953c2a2992f69066b7434..972955f9144aafcd3a3fe278b7aaad40
 +    cflags_c = [ "-Wdeprecated-literal-operator" ]
    }
  }
-diff --git a/deps/sqlite/unofficial.gni b/deps/sqlite/unofficial.gni
-index ebb3ffcd6d42b4c16b6865a91ccf4428cffe864b..00225afa1fb4205f1e02d9f185aeb97d642b3fd9 100644
---- a/deps/sqlite/unofficial.gni
-+++ b/deps/sqlite/unofficial.gni
-@@ -18,8 +18,14 @@ template("sqlite_gn_build") {
-     forward_variables_from(invoker, "*")
-     public_configs = [ ":sqlite_config" ]
-     sources = gypi_values.sqlite_sources
-+    cflags_c = [
-+      "-Wno-implicit-fallthrough",
-+      "-Wno-unreachable-code-break",
-+      "-Wno-unreachable-code-return",
-+      "-Wno-unreachable-code",
-+    ]
-     if (is_win) {
--      cflags_c = [
-+      cflags_c += [
-         "-Wno-sign-compare",
-         "-Wno-unused-but-set-variable",
-         "-Wno-unused-function",
-diff --git a/node.gni b/node.gni
 index 9dca810decebd75aab427e306b3cc37c80fb55c9..852f64fa9cfb50fe6e9ce7aa46be336d3196d5b8 100644
 --- a/node.gni
 +++ b/node.gni
@@ -52,13 +31,13 @@ index 9dca810decebd75aab427e306b3cc37c80fb55c9..852f64fa9cfb50fe6e9ce7aa46be336d
 -  node_path = "//node"
 +  node_path = "//third_party/electron_node"
 
-   # The location of V8, use the one from node's deps by default.
+   # The location of V8 - use the one from node's deps by default.
 -  node_v8_path = "$node_path/deps/v8"
 +  node_v8_path = "//v8"
 
-   # The NODE_MODULE_VERSION defined in node_version.h.
-   node_module_version = exec_script("$node_path/tools/getmoduleversion.py", [], "value")
-@@ -38,7 +38,7 @@ declare_args() {
+   # The location of OpenSSL - use the one from node's deps by default.
+   node_openssl_path = "$node_path/deps/openssl"
+@@ -44,7 +44,7 @@ declare_args() {
    node_openssl_system_ca_path = ""
 
    # Initialize v8 platform during node.js startup.
@@ -67,15 +46,15 @@ index 9dca810decebd75aab427e306b3cc37c80fb55c9..852f64fa9cfb50fe6e9ce7aa46be336d
 
    # Custom build tag.
    node_tag = ""
-@@ -58,7 +58,16 @@ declare_args() {
+@@ -64,10 +64,16 @@ declare_args() {
    # TODO(zcbenz): There are few broken things for now:
    #   1. cross-os compilation is not supported.
    #   2. node_mksnapshot crashes when cross-compiling for x64 from arm64.
 -  node_use_node_snapshot = (host_os == target_os) && !(host_cpu == "arm64" && target_cpu == "x64")
 +  node_use_node_snapshot = false
-+
-+  # Build with Amaro (TypeScript utils).
-+  node_use_amaro = true
+ 
+   # Build with Amaro (TypeScript utils).
+   node_use_amaro = true
 +
 +  # Allows downstream packagers (eg. Linux distributions) to build against system shared libraries.
 +  use_system_cares = false
@@ -98,39 +77,18 @@ index 1bec44f6f29b0b652e92d2bb336fdb74b85eee30..599b59873dbb17ae5e7463403859e088
 
  }  // namespace builtins
 diff --git a/src/node_builtins.h b/src/node_builtins.h
-index 1cb85b9058d06555382e565dc32192a9fa48ed9f..cec9be01abd107e8612f70daf19b4834e118ffcf 100644
+index a73de23a1debfdac66873e0baccf882e383bfc36..7ac5291be093773ee7efd39e77e01bf5d5ce5247 100644
 --- a/src/node_builtins.h
 +++ b/src/node_builtins.h
 @@ -74,6 +74,8 @@ using BuiltinCodeCacheMap =
- // Generated by tools/js2c.py as node_javascript.cc
+ // Generated by tools/js2c.cc as node_javascript.cc
  void RegisterExternalReferencesForInternalizedBuiltinCode(
      ExternalReferenceRegistry* registry);
 +void EmbedderRegisterExternalReferencesForInternalizedBuiltinCode(
 +    ExternalReferenceRegistry* registry);
 
  // Handles compilation and caching of built-in JavaScript modules and
  // bootstrap scripts, whose source are bundled into the binary as static data.
-diff --git a/tools/generate_config_gypi.py b/tools/generate_config_gypi.py
-index 45b3ac5006140fb55aad0e6b78084b753a947a76..35cce2ea8fd85f21582962115ac455918d4c4553 100755
---- a/tools/generate_config_gypi.py
-+++ b/tools/generate_config_gypi.py
-@@ -21,7 +21,7 @@ import getnapibuildversion
- GN_RE = re.compile(r'(\w+)\s+=\s+(.*?)$', re.MULTILINE)
- 
- if sys.platform == 'win32':
--  GN = 'gn.exe'
-+  GN = 'gn.bat'
- else:
-   GN = 'gn'
- 
-@@ -65,6 +65,7 @@ def translate_config(out_dir, config, v8_config):
-           eval(config['node_builtin_shareable_builtins']),
-       'node_module_version': int(config['node_module_version']),
-       'node_use_openssl': config['node_use_openssl'],
-+      'node_use_amaro': config['node_use_amaro'],
-       'node_use_node_code_cache': config['node_use_node_code_cache'],
-       'node_use_node_snapshot': config['node_use_node_snapshot'],
-       'v8_enable_inspector':  # this is actually a node misnomer
 diff --git a/tools/install.py b/tools/install.py
 index bf54249b66c0d4e179deaae5a9fd55568e694fe0..31b94d2e4b532d3b8202b512e2d2f41d29a2a546 100755
 --- a/tools/install.py
@@ -305,18 +263,6 @@ diff --git a/unofficial.gni b/unofficial.gni
 index c3b311e4a7f5444b07d4d7028d4621806959804e..f6793b8bf22d6ac911a1977edaa881b6dbbe7ac7 100644
 --- a/unofficial.gni
 +++ b/unofficial.gni
-@@ -22,6 +22,11 @@ template("node_gn_build") {
-     } else {
-       defines += [ "HAVE_OPENSSL=0" ]
-     }
-+    if (node_use_amaro) {
-+      defines += [ "HAVE_AMARO=1" ]
-+    } else {
-+      defines += [ "HAVE_AMARO=0" ]
-+    }
-     if (node_use_v8_platform) {
-       defines += [ "NODE_USE_V8_PLATFORM=1" ]
-     } else {
 @@ -139,6 +144,7 @@ template("node_gn_build") {
      public_deps = [
        "deps/ada",
@@ -325,14 +271,16 @@ index c3b311e4a7f5444b07d4d7028d4621806959804e..f6793b8bf22d6ac911a1977edaa881b6
        "deps/simdjson",
        "$node_v8_path",
      ]
-@@ -150,7 +156,6 @@ template("node_gn_build") {
+--- a/unofficial.gni
++++ b/unofficial.gni
+@@ -156,7 +156,6 @@ template("node_gn_build") {
        "deps/llhttp",
        "deps/nbytes",
        "deps/nghttp2",
 -      "deps/ngtcp2",
        "deps/postject",
-       "deps/simdutf",
        "deps/sqlite",
+       "deps/uvwasi",
 @@ -159,7 +164,11 @@ template("node_gn_build") {
        "$node_v8_path:v8_libplatform",
      ]
@@ -345,27 +293,23 @@ index c3b311e4a7f5444b07d4d7028d4621806959804e..f6793b8bf22d6ac911a1977edaa881b6
        "$target_gen_dir/node_javascript.cc",
      ] + gypi_values.node_sources
 
-@@ -178,8 +187,10 @@ template("node_gn_build") {
-       deps += [ "//third_party/icu" ]
+@@ -185,7 +185,7 @@ template("node_gn_build") {
      }
      if (node_use_openssl) {
--      deps += [ "deps/ncrypto" ]
--      public_deps += [ "deps/openssl" ]
-+      deps += [
-+        "deps/ncrypto",
-+        "//third_party/boringssl"
-+      ]
+       deps += [ "deps/ncrypto" ]
+-      public_deps += [ "$node_openssl_path" ]
++      public_deps += [ "//third_party/boringssl" ]
        sources += gypi_values.node_crypto_sources
      }
      if (node_enable_inspector) {
-@@ -276,6 +287,7 @@ template("node_gn_build") {
+@@ -282,6 +282,7 @@ template("node_gn_build") {
    }
 
    executable("node_js2c") {
 +    defines = []
      deps = [
-       "deps/simdutf",
        "deps/uv",
+       "$node_simdutf_path",
 @@ -286,26 +298,75 @@ template("node_gn_build") {
        "src/embedded_data.cc",
        "src/embedded_data.h",