Skip to content

Commit eacbbf5

Browse files
authored
feat(publish): add forcePathStyle option to S3Options (#8741)
1 parent 8fbc25c commit eacbbf5

5 files changed

Lines changed: 23 additions & 6 deletions

File tree

.changeset/four-gorillas-nail.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"builder-util": minor
3+
"builder-util-runtime": minor
4+
"electron-publish": minor
5+
---
6+
7+
Add `forcePathStyle` option to S3Options

packages/builder-util-runtime/src/publishOptions.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,12 @@ export interface S3Options extends BaseS3Options {
362362
* ${bucketname}.s3-accelerate.amazonaws.com
363363
*/
364364
readonly accelerate?: boolean
365+
366+
/**
367+
* When true, force a path-style endpoint to be used where the bucket name is part of the path.
368+
* [Path-style Access](https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access)
369+
*/
370+
readonly forcePathStyle?: boolean
365371
}
366372

367373
/**

packages/builder-util/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"dependencies": {
1818
"7zip-bin": "~5.2.0",
1919
"@types/debug": "^4.1.6",
20-
"app-builder-bin": "5.0.0-alpha.11",
20+
"app-builder-bin": "5.0.0-alpha.12",
2121
"bluebird-lst": "^1.0.9",
2222
"builder-util-runtime": "workspace:*",
2323
"chalk": "^4.1.2",

packages/electron-publish/src/s3/s3Publisher.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ export class S3Publisher extends BaseS3Publisher {
6161
if (this.info.encryption != null) {
6262
args.push("--encryption", this.info.encryption)
6363
}
64+
65+
if (this.info.forcePathStyle != null) {
66+
args.push("--forcePathStyle", this.info.forcePathStyle ? "true" : "false")
67+
}
6468
}
6569

6670
toString() {

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)