Skip to content

Commit 6e41480

Browse files
authored
fix: display product names with an & properly (#7831)
1 parent 549d07b commit 6e41480

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

.changeset/brown-parents-rest.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
fix(nsis): display product names with an `&` properly

packages/app-builder-lib/templates/nsis/common.nsh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@ ShowInstDetails nevershow
77
ShowUninstDetails nevershow
88
!endif
99
FileBufSize 64
10-
Name "${PRODUCT_NAME}"
10+
11+
# Allows for a product name to display properly if it has an ampersand
12+
# Doesn't affect anything if there is no double ampersand
13+
!searchreplace DoubleAmpersand "${PRODUCT_NAME}" "&" "&&"
14+
Name "${PRODUCT_NAME}" "${DoubleAmpersand}"
1115

1216
!define APP_EXECUTABLE_FILENAME "${PRODUCT_FILENAME}.exe"
1317
!define UNINSTALL_FILENAME "Uninstall ${PRODUCT_FILENAME}.exe"

0 commit comments

Comments
 (0)