Skip to content

Commit 633490c

Browse files
authored
fix(mac): always build dmg's with APFS (BREAKING) (#8782)
1 parent 8d6a600 commit 633490c

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

.changeset/cuddly-comics-cough.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"dmg-builder": major
3+
---
4+
5+
fix: removing conditional logic that would build HFS+ dmg on non-arm64 macs as HFS+ was sunset in macos 15.2

packages/dmg-builder/src/dmg.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -201,14 +201,7 @@ async function createStageDmg(tempDmg: string, appPath: string, volumeName: stri
201201
imageArgs.push("-debug")
202202
}
203203

204-
let filesystem = ["HFS+", "-fsargs", "-c c=64,a=16,e=16"]
205-
if (process.arch === "arm64") {
206-
// Apple Silicon `hdiutil` dropped support for HFS+, so we force the latest type
207-
// https://github.com/electron-userland/electron-builder/issues/4606
208-
filesystem = ["APFS"]
209-
log.warn(null, "Detected arm64 process, HFS+ is unavailable. Creating dmg with APFS - supports Mac OSX 10.12+")
210-
}
211-
imageArgs.push("-fs", ...filesystem)
204+
imageArgs.push("-fs", "APFS")
212205
imageArgs.push(tempDmg)
213206
await hdiUtil(imageArgs)
214207
return tempDmg

0 commit comments

Comments
 (0)