Skip to content

Commit 5a9141f

Browse files
authored
chore: add additional identity logging for mac os certificates (#8691)
1 parent 3d8e402 commit 5a9141f

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

.changeset/neat-buses-beg.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
chore(mac): add back logging of identity name and hash as opposed to just hash

packages/app-builder-lib/src/macPackager.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ export class MacPackager extends PlatformPackager<MacConfiguration> {
332332
provisioningProfile: customSignOptions.provisioningProfile || undefined,
333333
}
334334

335-
await this.doSign(signOptions, customSignOptions)
335+
await this.doSign(signOptions, customSignOptions, identity)
336336

337337
// https://github.com/electron-userland/electron-builder/issues/1196#issuecomment-312310209
338338
if (masOptions != null && !isDevelopment) {
@@ -411,16 +411,17 @@ export class MacPackager extends PlatformPackager<MacConfiguration> {
411411
}
412412

413413
//noinspection JSMethodCanBeStatic
414-
protected async doSign(opts: SignOptions, customSignOptions: MacConfiguration): Promise<void> {
414+
protected async doSign(opts: SignOptions, customSignOptions: MacConfiguration, identity: Identity | null): Promise<void> {
415415
const customSign = await resolveFunction(this.appInfo.type, customSignOptions.sign, "sign")
416416

417-
const { app, platform, type, identity, provisioningProfile } = opts
417+
const { app, platform, type, provisioningProfile } = opts
418418
log.info(
419419
{
420420
file: log.filePath(app),
421421
platform,
422422
type,
423-
identity: identity || "none",
423+
identityName: identity?.name || "none",
424+
identityHash: identity?.hash || "none",
424425
provisioningProfile: provisioningProfile || "none",
425426
},
426427
customSign ? "executing custom sign" : "signing"

0 commit comments

Comments
 (0)