File tree Expand file tree Collapse file tree
packages/app-builder-lib/src Expand file tree Collapse file tree Original file line number Diff line number Diff line change 1+ ---
2+ " app-builder-lib " : patch
3+ ---
4+
5+ fix(mac): only skip notarization step when ` notarize ` is explicitly false
Original file line number Diff line number Diff line change @@ -498,12 +498,13 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
498498
499499 private async notarizeIfProvided ( appPath : string , buildOptions : MacConfiguration ) {
500500 const notarizeOptions = buildOptions . notarize
501- if ( ! notarizeOptions ) {
502- log . info ( { reason : "`notarize` options were not provided " } , "skipped macOS notarization" )
501+ if ( notarizeOptions === false ) {
502+ log . info ( { reason : "`notarize` options were set explicitly `false` " } , "skipped macOS notarization" )
503503 return
504504 }
505505 const options = this . getNotarizeOptions ( appPath )
506506 if ( ! options ) {
507+ log . warn ( { reason : "`notarize` options were unable to be generated" } , "skipped macOS notarization" )
507508 return
508509 }
509510 await notarize ( options )
@@ -561,7 +562,7 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
561562 }
562563 return proj
563564 }
564- const { teamId } = options as NotarizeNotaryOptions
565+ const teamId = ( options as NotarizeNotaryOptions ) ?. teamId
565566 if ( ( teamId || options === true ) && ( legacyLogin || notaryToolLogin ) ) {
566567 const proj : NotaryToolStartOptions = {
567568 appPath,
You can’t perform that action at this time.
0 commit comments