Skip to content

Commit 509f118

Browse files
authored
chore: remove husky hooks, all test/lint scripts run in CI (#9360)
1 parent 811d13d commit 509f118

6 files changed

Lines changed: 3 additions & 342 deletions

File tree

.github/workflows/test.yaml

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,6 @@ jobs:
9898
docker image load --input ${{ runner.temp }}/electron-builder-all-${{ env.TEST_IMAGE_NODE_MAJOR_VERSION }}.tar
9999
docker image ls -a
100100
101-
- name: Lint
102-
run: pnpm pretest
103-
104101
- name: Run tests in docker image
105102
run: |
106103
echo $TEST_RUNNER_IMAGE_TAG
@@ -144,9 +141,6 @@ jobs:
144141
docker image load --input ${{ runner.temp }}/electron-builder-all-${{ env.TEST_IMAGE_NODE_MAJOR_VERSION }}.tar
145142
docker image ls -a
146143
147-
- name: Lint
148-
run: pnpm pretest
149-
150144
- name: Test
151145
run: |
152146
echo $TEST_RUNNER_IMAGE_TAG
@@ -262,11 +256,8 @@ jobs:
262256
cache-path: ~/Library/Caches/electron
263257
cache-key: v-23.3.10-macos-electron
264258

265-
- name: Install toolset via brew
266-
run: |
267-
brew install powershell/tap/powershell
268-
brew install --cask wine-stable
269-
brew install rpm
259+
- name: Lint
260+
run: pnpm pretest
270261

271262
- name: Test
272263
run: pnpm ci:test

.husky/.gitignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

.husky/pre-commit

Lines changed: 0 additions & 4 deletions
This file was deleted.

.husky/pre-push

Lines changed: 0 additions & 4 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,14 @@
22
"name": "@electron-builder/monorepo",
33
"private": true,
44
"license": "MIT",
5-
"lint-staged": {
6-
"packages/**/*.ts": "pnpm pretest",
7-
"**/package.json": "pnpm lint-deps",
8-
"scripts/checkDeps.ts": "pnpm lint-deps",
9-
"docs/**/*": "pnpm generate-docs",
10-
"packages/app-builder-lib/src/options/**/*": "pnpm generate-schema"
11-
},
125
"scripts": {
136
"//": "do not wrap into single quotes - windows doesn't unwrap arg in this case",
147
"compile": "tsc --build",
158
"lint": "eslint packages",
16-
"lint-staged": "lint-staged",
179
"lint-deps": "node ./scripts/checkDeps.js",
1810
"pretest": "pnpm lint-deps && pnpm lint",
1911
"prettier": "prettier 'packages/**/*.{ts,js}' test/src/**/*.ts --write",
2012
"///": "Please see https://github.com/electron-userland/electron-builder/blob/master/CONTRIBUTING.md#run-test-using-cli how to run particular test instead full (and very slow) run",
21-
"test-all": "pnpm compile && pnpm pretest && pnpm ci:test",
2213
"test-linux": "docker run --rm -e CI=${CI:-true} -e DEBUG=${DEBUG:-} -e UPDATE_SNAPSHOT=${UPDATE_SNAPSHOT:-false} -e TEST_FILES=\"${TEST_FILES:-HoistedNodeModuleTest}\" -w /project -v $(pwd):/project -v $(pwd)-node-modules:/project/node_modules -v $HOME/Library/Caches/electron:/root/.cache/electron -v $HOME/Library/Caches/electron-builder:/root/.cache/electron-builder ${ADDITIONAL_DOCKER_ARGS} ${TEST_RUNNER_IMAGE_TAG:-electronuserland/builder:22-wine-mono} /bin/bash -c \"corepack enable && pnpm install && pnpm ci:test\"",
2314
"test-update": "UPDATE_SNAPSHOT=true vitest run",
2415
"test-ui": "vitest --ui",
@@ -35,8 +26,7 @@
3526
"docs:build": "pnpm compile && ts-node scripts/renderer/src/typedoc2html.ts",
3627
"docs:mkdocs": "docker run --rm -v ${PWD}:/docs -v ${PWD}/site:/site mkdocs-dockerfile build",
3728
"docs:preview": "open ./site/index.html",
38-
"docs:all": "pnpm docs:prebuild && pnpm docs:build && pnpm docs:mkdocs",
39-
"prepare": "husky install"
29+
"docs:all": "pnpm docs:prebuild && pnpm docs:build && pnpm docs:mkdocs"
4030
},
4131
"repository": "https://github.com/electron-userland/electron-builder",
4232
"dependencies": {
@@ -61,8 +51,6 @@
6151
"eslint-config-prettier": "^9.1.0",
6252
"eslint-plugin-prettier": "^5.2.1",
6353
"fs-extra": "10.1.0",
64-
"husky": "7.0.4",
65-
"lint-staged": "15.2.10",
6654
"prettier": "3.3.3",
6755
"ts-node": "^10.9.2",
6856
"typedoc": "^0.26.7",

0 commit comments

Comments
 (0)