Skip to content

Commit 4c6d154

Browse files
authored
fix: signing of user-defined binaries on mac when resolved as relative path (#6660)
1 parent 8db6c72 commit 4c6d154

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"app-builder-lib": patch
3+
---
4+
5+
Fix error thrown due to duplicated signing of user-defined binaries on mac when resolving relative path

packages/app-builder-lib/src/macPackager.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -243,17 +243,15 @@ export default class MacPackager extends PlatformPackager<MacConfiguration> {
243243
let binaries = options.binaries || undefined
244244
if (binaries) {
245245
// Accept absolute paths for external binaries, else resolve relative paths from the artifact's app Contents path.
246-
const userDefinedBinaries = await Promise.all(
246+
binaries = await Promise.all(
247247
binaries.map(async destination => {
248248
if (await statOrNull(destination)) {
249249
return destination
250250
}
251251
return path.resolve(appPath, destination)
252252
})
253253
)
254-
// Insert at front to prioritize signing. We still sort by depth next
255-
binaries = userDefinedBinaries.concat(binaries)
256-
log.info("Signing addtional user-defined binaries: " + JSON.stringify(userDefinedBinaries, null, 1))
254+
log.info("Signing addtional user-defined binaries: " + JSON.stringify(binaries, null, 1))
257255
}
258256

259257
const signOptions: any = {

0 commit comments

Comments
 (0)