Add security exception list #1495
Draft
+1,151
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-benoit
force-pushed
the
add_security_exception_list
branch
from
febf285 to
e385ba4
Compare
…tack into add_security_exception_list
nick-benoit
force-pushed
the
add_security_exception_list
branch
from
5680581 to
3980a35
Compare
tobio
reviewed
Nov 28, 2025
|
|
||
| switch resp.StatusCode() { | ||
| case http.StatusOK: | ||
| return resp, nil |
Member
There was a problem hiding this comment.
Suggested change
| return resp, nil | |
| return resp.JSON200, nil |
Comment on lines
57
to
67
| MarkdownDescription: "The type of exception list. Can be one of: `detection`, `endpoint`, `endpoint_trusted_apps`, `endpoint_events`, `endpoint_host_isolation_exceptions`, `endpoint_blocklists`.", | ||
| Required: true, | ||
| Validators: []validator.String{ | ||
| stringvalidator.OneOf( | ||
| "detection", | ||
| "endpoint", | ||
| "endpoint_trusted_apps", | ||
| "endpoint_events", | ||
| "endpoint_host_isolation_exceptions", | ||
| "endpoint_blocklists", | ||
| ), |
Member
There was a problem hiding this comment.
We have the same thing in #1489 and I didn't comment on it there. :/
WDYT about pulling the list of valid options out to a variable so we could do something like this mashup of Golang and Javascript but in a way that actually compiles.
Suggested change
| MarkdownDescription: "The type of exception list. Can be one of: `detection`, `endpoint`, `endpoint_trusted_apps`, `endpoint_events`, `endpoint_host_isolation_exceptions`, `endpoint_blocklists`.", | |
| Required: true, | |
| Validators: []validator.String{ | |
| stringvalidator.OneOf( | |
| "detection", | |
| "endpoint", | |
| "endpoint_trusted_apps", | |
| "endpoint_events", | |
| "endpoint_host_isolation_exceptions", | |
| "endpoint_blocklists", | |
| ), | |
| MarkdownDescription: fmt.Sprintf("The type of exception list. Can be one of: %s.", strings.Join(validExceptionListTypes.Map(t => "`${t}`"), ", ")), | |
| Required: true, | |
| Validators: []validator.String{ | |
| stringvalidator.OneOf( | |
| validExceptionListTypes... | |
| ), |
| }, | ||
| }, | ||
| "os_types": schema.ListAttribute{ | ||
| MarkdownDescription: "Array of OS types for which the exceptions apply. Valid values: `linux`, `macos`, `windows`.", |
Member
There was a problem hiding this comment.
Should we have a OneOf validator here?
| } | ||
|
|
||
| // Build the request body | ||
| body := kbapi.CreateExceptionListJSONRequestBody{ |
Member
There was a problem hiding this comment.
Can we move this into a function in models.go
| Optional: true, | ||
| ElementType: types.StringType, | ||
| }, | ||
| "tags": schema.ListAttribute{ |
Member
There was a problem hiding this comment.
Suggested change
| "tags": schema.ListAttribute{ | |
| "tags": schema.SetAttribute{ |
Do duplicates matter? Should we be worried about the API returning these in a different order?
| ClusterId: model.SpaceID.ValueString(), | ||
| ResourceId: string(apiResp.Id), | ||
| } | ||
| model.ID = types.StringValue(compId.String()) |
Member
There was a problem hiding this comment.
Similarly can we build the model in models.go
| stringplanmodifier.RequiresReplace(), | ||
| }, | ||
| }, | ||
| "os_types": schema.ListAttribute{ |
Member
There was a problem hiding this comment.
Suggested change
| "os_types": schema.ListAttribute{ | |
| "os_types": schema.SetAttribute{ |
Similarly I suspect this should be a set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.