Fix segfaults during Create/Update for ec_deployment.#719
Merged
Conversation
danielmitterdorfer
approved these changes
Sep 29, 2023
danielmitterdorfer
left a comment
danielmitterdorfer
left a comment
There was a problem hiding this comment.
I've tested my reproduction scenario mentioned in #715 with this change and it works fine now. Thanks for the super quick fix!
dimuon
enabled auto-merge (squash)
October 2, 2023 10:22
- when `elasticsearch` attribute contains both `strategy` and `snapshot_source`; - when `elasticsearch` defines `snapshot` with `repository` that doesn't contain `reference`.
dimuon
force-pushed
the
GH-715/fix-segfaults
branch
from
October 2, 2023 10:23
cd641f3 to
c13fabf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix segfaults during Create/Update for
ec_deploymentelasticsearchattribute contains bothstrategyandsnapshot_source;elasticsearchdefinessnapshotwithrepositorythat doesn't containreference.Description
Related Issues
Closes: #715
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist