Commit a582800
authored
# Backport
This will backport the following commits from `main` to `7.17`:
- [[APM][ML] Update cytoscape with new index.d.ts def, fix typing issues
(#206651)](#206651)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da
Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-20T13:36:22Z","message":"[APM][ML]
Update cytoscape with new index.d.ts def, fix typing issues
(#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver
breaking change, affecting\r\ntyping once more in a couple of places.
They now have their own\r\n`index.d.ts` file for Typescript support, but
this causes some issues as\r\nthey don't always have the same type name
as the `@types` version. Had\r\nto fix in a couple of places, both in
APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to
test\r\n\r\n* This PR passes the CI with no typing issues, or failed
tests\r\n* Going to APM or ML pages with cytoscape being loaded shows
no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:all-open","Team:obs-ux-infra_services"],"title":"[APM][ML]
Update cytoscape with new index.d.ts def, fix typing
issues","number":206651,"url":"https://github.com/elastic/kibana/pull/206651","mergeCommit":{"message":"[APM][ML]
Update cytoscape with new index.d.ts def, fix typing issues
(#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver
breaking change, affecting\r\ntyping once more in a couple of places.
They now have their own\r\n`index.d.ts` file for Typescript support, but
this causes some issues as\r\nthey don't always have the same type name
as the `@types` version. Had\r\nto fix in a couple of places, both in
APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to
test\r\n\r\n* This PR passes the CI with no typing issues, or failed
tests\r\n* Going to APM or ML pages with cytoscape being loaded shows
no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206651","number":206651,"mergeCommit":{"message":"[APM][ML]
Update cytoscape with new index.d.ts def, fix typing issues
(#206651)\n\n## Summary\r\n\r\n`cytoscape` released yet another semver
breaking change, affecting\r\ntyping once more in a couple of places.
They now have their own\r\n`index.d.ts` file for Typescript support, but
this causes some issues as\r\nthey don't always have the same type name
as the `@types` version. Had\r\nto fix in a couple of places, both in
APM and in ML codebases.\r\n\r\nSupersedes #206498\r\n\r\n## How to
test\r\n\r\n* This PR passes the CI with no typing issues, or failed
tests\r\n* Going to APM or ML pages with cytoscape being loaded shows
no\r\nregressions.","sha":"a0bdc1968456f0db02a18becefdc19bdcc5469f5"}}]}]
BACKPORT-->
1 parent 8486791 commit a582800
File tree
3 files changed
+6
-12
lines changed- x-pack/plugins/apm/public/components/app/service_map
3 files changed
+6
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| |||
514 | 514 | | |
515 | 515 | | |
516 | 516 | | |
517 | | - | |
518 | 517 | | |
519 | 518 | | |
520 | 519 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5504 | 5504 | | |
5505 | 5505 | | |
5506 | 5506 | | |
5507 | | - | |
5508 | | - | |
5509 | | - | |
5510 | | - | |
5511 | | - | |
5512 | 5507 | | |
5513 | 5508 | | |
5514 | 5509 | | |
| |||
10758 | 10753 | | |
10759 | 10754 | | |
10760 | 10755 | | |
10761 | | - | |
10762 | | - | |
10763 | | - | |
10764 | | - | |
| 10756 | + | |
| 10757 | + | |
| 10758 | + | |
| 10759 | + | |
10765 | 10760 | | |
10766 | 10761 | | |
10767 | 10762 | | |
| |||
0 commit comments