Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] add value to disable service #1115

Merged
merged 1 commit into from
Jul 6, 2021
Merged

[elasticsearch] add value to disable service #1115

merged 1 commit into from
Jul 6, 2021

Conversation

@nflaig
Copy link
Contributor

@nflaig nflaig commented Mar 18, 2021 •
edited
Loading

Hey guys,

right now it is not possible to completely disable the service but it is not required if the helm chart is deployed to a cluster with a service mesh (consul, istio, etc.).

Since the service.enabled does not apply to the headless service a different name could be considered but I think the issue rather is that both services use the same service value rather than service and serviceHeadless.

Fix #998

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2021

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 18, 2021 •
edited
Loading

💚 CLA has been signed

@nflaig nflaig force-pushed the feature/disable_service branch from 358a6ff to 30e0341 Compare March 18, 2021 20:57
jmlrt
jmlrt previously approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt jmlrt added elasticsearch enhancement New feature or request labels Apr 12, 2021
@jmlrt
Copy link
Member

jmlrt commented Apr 12, 2021

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Apr 12, 2021

will need to be rebased after #1141 merge to fix tests

@nflaig nflaig force-pushed the feature/disable_service branch 2 times, most recently from 4a0a0c0 to 210671e Compare April 12, 2021 21:14
@nflaig
Copy link
Contributor Author

nflaig commented Apr 12, 2021

@jmlrt Thanks for the review! I added the new value to the README and will rebase the branch if required

@jmlrt jmlrt force-pushed the feature/disable_service branch from 139ab8c to a0350f1 Compare July 6, 2021 07:46
@jmlrt
Copy link
Member

jmlrt commented Jul 6, 2021

jenkins test this please

jmlrt
jmlrt reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nflaig, I rebased your branch on master and fixed the conflicts.
The change LGTM to me.

Adding a test in https://github.com/elastic/helm-charts/blob/master/elasticsearch/tests/elasticsearch_test.py to ensure that the service isn't created when setting service.enabled=false would be great.

Are you interested in adding this test? Otherwise I think we can merge if tests are successful.

@nflaig nflaig force-pushed the feature/disable_service branch from a0350f1 to d80aeaf Compare July 6, 2021 12:27
@nflaig
Copy link
Contributor Author

nflaig commented Jul 6, 2021

@jmlrt Thanks for rebasing the branch. I added a test to check if disabling the service works as expected if service.enabled is set to false. Also I noticed that the commit message was somehow overwritten I updated the commit to have the original message, I hope thats fine

@nflaig nflaig force-pushed the feature/disable_service branch from d80aeaf to 3f8e99e Compare July 6, 2021 12:36
@nflaig nflaig force-pushed the feature/disable_service branch from 3f8e99e to c63ecfd Compare July 6, 2021 12:42
@jmlrt
Copy link
Member

jmlrt commented Jul 6, 2021

Thanks for rebasing the branch. I added a test to check if disabling the service works as expected if service.enabled is set to false.

👍🏻

Also I noticed that the commit message was somehow overwritten I updated the commit to have the original message, I hope thats fine

Yes, sorry I messed it a bit while rebasing...

@jmlrt
Copy link
Member

jmlrt commented Jul 6, 2021

jenkins test this please

@jmlrt jmlrt merged commit 0e5a168 into elastic:master Jul 6, 2021
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Sep 13, 2021
@nflaig @jmlrt
[elasticsearch] add value to disable service (elastic#1115)
ecd064c 
Signed-off-by: nflaig <[email protected]>
@jmlrt jmlrt mentioned this pull request Sep 13, 2021
Merged
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Sep 13, 2021
@nflaig @jmlrt
[elasticsearch] add value to disable service (elastic#1115)
cc7e658 
Signed-off-by: nflaig <[email protected]>
@jmlrt jmlrt mentioned this pull request Sep 13, 2021
Merged
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Sep 13, 2021
@nflaig @jmlrt
[elasticsearch] add value to disable service (elastic#1115)
b845961 
Signed-off-by: nflaig <[email protected]>
@jmlrt jmlrt mentioned this pull request Sep 13, 2021
Merged
jmlrt added a commit that referenced this pull request Sep 21, 2021
@jmlrt @nflaig
[elasticsearch] add value to disable service (#1115) (#1338)
4190bd7 
Signed-off-by: nflaig <[email protected]>

Co-authored-by: Nico Flaig <[email protected]>
jmlrt added a commit that referenced this pull request Sep 21, 2021
@jmlrt @nflaig
[elasticsearch] add value to disable service (#1115) (#1339)
e10cdbd 
Signed-off-by: nflaig <[email protected]>

Co-authored-by: Nico Flaig <[email protected]>
@jmlrt jmlrt added the v7.14.2 label Sep 21, 2021
jmlrt added a commit that referenced this pull request Sep 21, 2021
@jmlrt @nflaig
[elasticsearch] add value to disable service (#1115) (#1340)
8f0729a 
Signed-off-by: nflaig <[email protected]>

Co-authored-by: Nico Flaig <[email protected]>
@jmlrt jmlrt mentioned this pull request Sep 22, 2021
Merged
jmlrt pushed a commit to jmlrt/helm-charts that referenced this pull request Sep 22, 2021
@nflaig @jmlrt
[elasticsearch] add value to disable service (elastic#1115)
e9a7d98 
Signed-off-by: nflaig <[email protected]>
jmlrt added a commit that referenced this pull request Sep 22, 2021
@jmlrt @nflaig
[elasticsearch] add value to disable service (#1115) (#1366)
5972a4c 
Signed-off-by: nflaig <[email protected]>

Co-authored-by: Nico Flaig <[email protected]>
@elasticmachine elasticmachine mentioned this pull request Sep 27, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Merged
Merged
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
Merged
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
Merged
This was referenced Sep 14, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jmlrt jmlrt jmlrt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported elasticsearch enhancement New feature or request v6.8.19 v7.14.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[elasticsearch] Add "service.enabled" parameter

3 participants

@nflaig @elasticmachine @jmlrt