[elasticsearch] add value to disable tests (#1116) (#1342)

* [elasticsearch] add value to disable tests

Signed-off-by: nflaig <[email protected]>

* [elasticsearch] add condition to not print test command when the test is disabled

Signed-off-by: nflaig <[email protected]>

Co-authored-by: Julien Mailleret <[email protected]>

Co-authored-by: Nico Flaig <[email protected]>

Author: jmlrt

elasticsearch/README.md

@@ -174,6 +174,7 @@ support multiple versions with minimal changes.
 | `sysctlInitContainer`              | Allows you to disable the `sysctlInitContainer` if you are setting [sysctl vm.max_map_count][] with another method                                                                                                                                                                                                | `enabled: true`                                  |
 | `sysctlVmMaxMapCount`              | Sets the [sysctl vm.max_map_count][] needed for Elasticsearch                                                                                                                                                                                                                                                     | `262144`                                         |
 | `terminationGracePeriod`           | The [terminationGracePeriod][] in seconds used when trying to stop the pod                                                                                                                                                                                                                                        | `120`                                            |
+| `tests.enabled`                    | Enable creating test related resources when running `helm template` or `helm test`                                                                                                                                                                                                                                | `true`                                           |
 | `tolerations`                      | Configurable [tolerations][]                                                                                                                                                                                                                                                                                      | `[]`                                             |
 | `transportPort`                    | The transport port that Kubernetes will use for the service. If you change this you will also need to set [transport port configuration][] in `extraEnvs`                                                                                                                                                         | `9300`                                           |
 | `updateStrategy`                   | The [updateStrategy][] for the StatefulSet. By default Kubernetes will wait for the cluster to be green after upgrading each pod. Setting this to `OnDelete` will allow you to manually delete each pod during upgrades                                                                                           | `RollingUpdate`                                  |

elasticsearch/templates/NOTES.txt

@@ -1,4 +1,6 @@
 1. Watch all cluster members come up.
   $ kubectl get pods --namespace={{ .Release.Namespace }} -l app={{ template "elasticsearch.uname" . }} -w
+{{- if .Values.tests.enabled -}}
 2. Test cluster health using Helm test.
-  $ helm test {{ .Release.Name }}
+  $ helm --namespace={{ .Release.Namespace }} test {{ .Release.Name }}
+{{- end -}}

elasticsearch/templates/test/test-elasticsearch-health.yaml

@@ -1,4 +1,5 @@
 ---
+{{- if .Values.tests.enabled -}}
 apiVersion: v1
 kind: Pod
 metadata:
@@ -32,3 +33,4 @@ spec:
 {{ toYaml .Values.imagePullSecrets | indent 4 }}
   {{- end }}
   restartPolicy: Never
+{{- end -}}

elasticsearch/values.yaml

@@ -336,6 +336,9 @@ networkPolicy:
     #           values:
     #             - frontend
 
+tests:
+  enabled: true
+
 # Deprecated
 # please use the above podSecurityContext.fsGroup instead
 fsGroup: ""