test: log file at the end

Author: kruskall

systemtest/apmservertest/server.go

@@ -139,20 +139,21 @@ func NewUnstartedServerTB(tb testing.TB, args ...string) *Server {
 	logfile := createLogfile(tb, "apm-server")
 	s.Log = logfile
 	tb.Cleanup(func() {
+		defer func() {
+			if tb.Failed() {
+				b, err := os.ReadFile(logfile.Name())
+				if err != nil {
+					tb.Fatal(err)
+				}
+
+				tb.Log(string(b))
+			}
+		}()
 		defer logfile.Close()
 		if tb.Failed() {
 			tb.Logf("log file: %s", logfile.Name())
 		}
 
-		if tb.Failed() {
-			b, err := io.ReadAll(logfile)
-			if err != nil {
-				tb.Fatal(err)
-			}
-
-			tb.Log(string(b))
-		}
-
 		// Call the server's Close method in a background goroutine,
 		// and wait for up to 10 seconds for it to complete.
 		errc := make(chan error)