-
-
Notifications
You must be signed in to change notification settings - Fork 116
Implemented IJSInProcessRuntime and IJSUnmarshalledRuntime interf…
#279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…aces for `BUnitJSRuntime`
Codecov Report
@@ Coverage Diff @@
## dev #279 +/- ##
==========================================
+ Coverage 82.61% 82.64% +0.02%
==========================================
Files 118 118
Lines 3607 3612 +5
Branches 468 468
==========================================
+ Hits 2980 2985 +5
Misses 480 480
Partials 147 147
Continue to review full report at Codecov.
|
egil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good I think. Besides a few missing "happy path tests" in strict mode, I think you are almost there.
…and parsed an empty array instead of null to `InvokeUnmarshalled` with no arguments.
egil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes looks good to me.
|
I will just add some more tests for the "happy path tests" later today. Do you think it's ready for non-draft Pull-Request after that? |
egil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only seem to be missing some happy path IJSUnmarshalledRuntime tests.
|
I unchecked the |
… test class partial
egil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
It was ready to begin with 🙂 Just missing the happy path tests, then we can close this. |
egil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few code style/code cleanup tidbits here, but otherwise I think we are done.
egil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks.
Pull request description
Pull request for issue #222
I use
#IF NET5_0in the middle of namespaces/classes to differentiate what can be implemented in the different versions. This might not follow the AspNetCore coding guidelines.PR meta checklist
DEVbranch.Content checklist