Skip to content

Conversation

@egil
Copy link
Member

@egil egil commented Oct 23, 2020

Pull request description

Implementation #155.

PR meta checklist

  • Pull request is targeting at DEV branch.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Content checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@egil egil linked an issue Oct 23, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #236 into dev will increase coverage by 0.25%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #236      +/-   ##
==========================================
+ Coverage   80.70%   80.96%   +0.25%     
==========================================
  Files         110      112       +2     
  Lines        3307     3394      +87     
  Branches      422      430       +8     
==========================================
+ Hits         2669     2748      +79     
- Misses        506      516      +10     
+ Partials      132      130       -2     
Impacted Files Coverage Δ
src/bunit.core/RazorTesting/RazorTestBase.cs 84.61% <ø> (ø)
.../bunit.core/ComponentParameterCollectionBuilder.cs 82.10% <88.23%> (+0.85%) ⬆️
src/bunit.core/TestContextBase.cs 100.00% <100.00%> (ø)
src/bunit.web/Rendering/RootRenderTree.cs 100.00% <100.00%> (ø)
.../bunit.web/Rendering/RootRenderTreeRegistration.cs 100.00% <100.00%> (ø)
src/bunit.web/TestContext.cs 100.00% <100.00%> (ø)
src/bunit.web/Extensions/TestRendererExtensions.cs 25.00% <0.00%> (-31.25%) ⬇️
...it.core/Extensions/WaitForHelpers/WaitForHelper.cs 87.50% <0.00%> (-2.50%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea8ee0...7168943. Read the comment docs.

@egil egil changed the title AddLayoutComponent TestContext.RenderTree Oct 23, 2020
@egil egil merged commit 92779eb into dev Oct 24, 2020
@egil egil deleted the feature/155-layout branch October 24, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable adding parent components and cascading values to test contexts

2 participants