Merged
Conversation
fengmk2
reviewed
Dec 21, 2022
| // should wait all handlers done then destroy ctx | ||
| e.message = `[EventBus] process event ${String(event)} failed: ${e.message}`; | ||
| this.logger.error(e); | ||
| await ContextHandler.run(ctx, async () => { |
Codecov ReportBase: 92.23% // Head: 91.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 92.23% 91.71% -0.53%
==========================================
Files 217 222 +5
Lines 4368 4512 +144
Branches 447 460 +13
==========================================
+ Hits 4029 4138 +109
- Misses 338 374 +36
+ Partials 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ff81b42 to
15fadf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change