Skip to content

fix: use require.resolve instead path.join to resolve dependencies path#63

Merged
killagu merged 8 commits intoeggjs:masterfrom
qile222:master
Dec 8, 2022
Merged

fix: use require.resolve instead path.join to resolve dependencies path#63
killagu merged 8 commits intoeggjs:masterfrom
qile222:master

Conversation

@qile222
Copy link
Contributor

@qile222 qile222 commented Dec 6, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 92.18% // Head: 92.18% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (75d97c9) compared to base (16640eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         217      217           
  Lines        4363     4364    +1     
  Branches      421      420    -1     
=======================================
+ Hits         4022     4023    +1     
- Misses        340      341    +1     
+ Partials        1        0    -1     
Impacted Files Coverage Δ
core/common-util/src/ModuleConfig.ts 75.00% <100.00%> (+0.89%) ⬆️
plugin/orm/lib/ContextModelProto.ts 74.07% <0.00%> (-3.71%) ⬇️
plugin/orm/lib/DataSourceManager.ts 53.84% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@killagu killagu merged commit d7f3beb into eggjs:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants