fix: use require.resolve instead path.join to resolve dependencies path#63
Merged
killagu merged 8 commits intoeggjs:masterfrom Dec 8, 2022
Merged
fix: use require.resolve instead path.join to resolve dependencies path#63killagu merged 8 commits intoeggjs:masterfrom
killagu merged 8 commits intoeggjs:masterfrom
Conversation
fengmk2
approved these changes
Dec 7, 2022
killagu
reviewed
Dec 7, 2022
killagu
reviewed
Dec 7, 2022
qile222
commented
Dec 7, 2022
killagu
reviewed
Dec 8, 2022
Codecov ReportBase: 92.18% // Head: 92.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 217 217
Lines 4363 4364 +1
Branches 421 420 -1
=======================================
+ Hits 4022 4023 +1
- Misses 340 341 +1
+ Partials 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change