Skip to content

feat: impl Schedule decorator#52

Merged
killagu merged 1 commit intomasterfrom
feat/schedule
Sep 4, 2022
Merged

feat: impl Schedule decorator#52
killagu merged 1 commit intomasterfrom
feat/schedule

Conversation

@killagu
Copy link
Contributor

@killagu killagu commented Sep 2, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@killagu killagu requested review from hyj1991 and whxaxes September 2, 2022 08:56
@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2022

This pull request introduces 1 alert when merging d9145e2 into 2d297e6 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@killagu
Copy link
Contributor Author

killagu commented Sep 2, 2022

eggjs/schedule#56

@killagu killagu changed the title WIP: feat: impl Schedule decorator feat: impl Schedule decorator Sep 3, 2022
@lgtm-com
Copy link

lgtm-com bot commented Sep 3, 2022

This pull request introduces 1 alert when merging a238704 into 43b885a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Base: 92.06% // Head: 92.13% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (d3d0338) compared to base (43b885a).
Patch coverage: 93.78% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   92.06%   92.13%   +0.06%     
==========================================
  Files         199      215      +16     
  Lines        4122     4283     +161     
  Branches      399      410      +11     
==========================================
+ Hits         3795     3946     +151     
- Misses        326      336      +10     
  Partials        1        1              
Impacted Files Coverage Δ
...chedule-decorator/src/util/ScheduleMetadataUtil.ts 71.42% <71.42%> (ø)
...e/schedule-decorator/src/model/ScheduleMetadata.ts 76.92% <76.92%> (ø)
...re/schedule-decorator/src/util/ScheduleInfoUtil.ts 88.23% <88.23%> (ø)
core/schedule-decorator/src/decorator/Schedule.ts 91.66% <91.66%> (ø)
...edule-decorator/src/builder/ScheduleMetaBuilder.ts 92.30% <92.30%> (ø)
plugin/schedule/lib/ScheduleWorkerLoadUnitHook.ts 92.30% <92.30%> (ø)
core/schedule-decorator/index.ts 100.00% <100.00%> (ø)
core/tegg/index.ts 100.00% <100.00%> (ø)
core/tegg/schedule.ts 100.00% <100.00%> (ø)
plugin/config/agent.ts 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lgtm-com
Copy link

lgtm-com bot commented Sep 3, 2022

This pull request introduces 1 alert when merging 7ef243e into 43b885a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 3, 2022

This pull request introduces 1 alert when merging 3567d36 into 43b885a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 3, 2022

This pull request introduces 1 alert when merging c4461b7 into 43b885a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 3, 2022

This pull request introduces 1 alert when merging f1e3b83 into 43b885a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@killagu killagu changed the title feat: impl Schedule decorator wip: feat: impl Schedule decorator Sep 3, 2022
@killagu killagu changed the title wip: feat: impl Schedule decorator feat: impl Schedule decorator Sep 4, 2022
@killagu killagu merged commit 7f95005 into master Sep 4, 2022
@killagu killagu deleted the feat/schedule branch September 4, 2022 06:42
@killagu
Copy link
Contributor Author

killagu commented Sep 4, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants