Conversation
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 92.00% 92.02% +0.02%
==========================================
Files 196 196
Lines 3950 3960 +10
Branches 378 384 +6
==========================================
+ Hits 3634 3644 +10
Misses 315 315
Partials 1 1
Continue to review full report at Codecov.
|
killagu
reviewed
Jul 1, 2022
Contributor
@Inject(TestService)
testService: TestService;这样代码太冗余了。 |
Member
Author
|
改成只支持传 name 的简写了 |
Member
Author
|
@killagu 再看一下? |
killagu
reviewed
Jul 1, 2022
core/core-decorator/test/fixtures/decators/QualifierCacheService.ts
Outdated
Show resolved
Hide resolved
whxaxes
commented
Jul 1, 2022
| @Inject() | ||
| foo: Foo; | ||
| export class Foo extends Base { | ||
|
|
Member
Author
There was a problem hiding this comment.
加了 emitDecoratorMetadata ,下面的引用编译成 js 也实际存在了,所以这里顺序要改到引用前面
ea43087 to
da341fd
Compare
Member
Author
|
加上 design:type 的支持了,@killagu 再看一下? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
优化 Inject 逻辑,让 Inject 更简单易用,可以直接 Inject name ,也支持通过 design:type 来获取 protoClass
Description of change