feat: add mcp middleware hook#344
Conversation
Summary of ChangesHello @JasmineLCY, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature that provides extensible middleware hooks for the MCP (Micro-Controller-Proxy) system. It allows developers to inject custom logic to be executed both before and after the core MCP middleware processing, enhancing control and observability over request flows within the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a middleware hook mechanism for MCP, allowing custom logic to be executed at the start and end of MCP middleware processing. The changes include defining the hook interface, integrating it into the MCP middleware, and passing the hooks via the application configuration. The implementation is sound and is accompanied by tests. I have a couple of suggestions to improve the robustness of the test hook implementation and reduce code duplication in the tests.
Checklist
npm testpassesAffected core subsystem(s)
Description of change