fix: fix total type in paginate

[killagu]

Checklist

• npm test passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

Description of change

Summary by CodeRabbit

• Bug Fixes

  • Corrected data type for total count in pagination results to ensure accurate numeric values.

• Tests

  • Added a test case to verify accurate total count in pagination results.

[coderabbitai]

Walkthrough

The changes involve a minor but significant update to the DataSource.ts file, where the total property is now explicitly cast to a Number, potentially improving type safety and correctness. Additionally, a new test case has been added to DataSource.test.ts to ensure that the paginate method correctly handles scenarios where the total count is 0.

Changes

File Path	Description
core/dal-runtime/src/DataSource.ts	Changed total: ret[1] to total: Number(ret[1]) in getDataPage method.
core/dal-runtime/test/DataSource.test.ts	Added a new test case for the paginate method to assert total as 0.

Poem

In the world of code where numbers play,
Our DataSource now knows the way.
Zero or more, it counts with glee,
Solidity in type, as clear as can be.
A test to show its might and cheer,
With each change, we persevere! 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 35ed76f and 0f75b0a.

Files selected for processing (2)

• core/dal-runtime/src/DataSource.ts (1 hunks)
• core/dal-runtime/test/DataSource.test.ts (1 hunks)

Additional comments not posted (2)

core/dal-runtime/src/DataSource.ts (1)

80-80: Ensure type consistency by converting total to a number.

The explicit conversion of total to a number enhances type safety and correctness. This change is approved.

core/dal-runtime/test/DataSource.test.ts (1)

149-151: New test case verifies paginate method behavior.

The new test case ensures that the paginate method correctly identifies a total count of 0. This test validates the recent modification and ensures the method handles edge cases correctly.