feat(eventbus): allow a handler to subscribe to multiple events#179
Merged
killagu merged 4 commits intoeggjs:masterfrom Dec 26, 2023
Merged
feat(eventbus): allow a handler to subscribe to multiple events#179killagu merged 4 commits intoeggjs:masterfrom
killagu merged 4 commits intoeggjs:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 92.52% 92.62% +0.09%
==========================================
Files 235 236 +1
Lines 5020 5055 +35
Branches 539 544 +5
==========================================
+ Hits 4645 4682 +37
+ Misses 375 373 -2 ☔ View full report in Codecov by Sentry. |
killagu
reviewed
Dec 21, 2023
killagu
reviewed
Dec 26, 2023
killagu
reviewed
Dec 26, 2023
Contributor
|
🎉实现的非常好。感谢。 |
Contributor
Author
|
deprecated 的接口没覆盖到，覆盖率掉了，我补下单测 |
fengmk2
reviewed
Dec 26, 2023
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
plugin/eventbuseventbus-decoratoreventbus-runtimeDescription of change
allow a handler to subscribe to multiple events