Skip to content

fix: config for env is not merged when default config is empty#178

Merged
killagu merged 2 commits intomasterfrom
fix/empty-config
Jan 16, 2024
Merged

fix: config for env is not merged when default config is empty#178
killagu merged 2 commits intomasterfrom
fix/empty-config

Conversation

@gxkl
Copy link
Contributor

@gxkl gxkl commented Dec 15, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gxkl gxkl requested review from fengmk2 and killagu December 15, 2023 07:13
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04fabef) 92.52% compared to head (008c9c7) 92.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   92.52%   92.52%   -0.01%     
==========================================
  Files         235      235              
  Lines        5020     5019       -1     
  Branches      539      539              
==========================================
- Hits         4645     4644       -1     
  Misses        375      375              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@killagu killagu merged commit 9c1de22 into master Jan 16, 2024
@killagu killagu deleted the fix/empty-config branch January 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants