Skip to content

feat: getObject support MultiInstanceProto#161

Merged
fengmk2 merged 1 commit intomasterfrom
feat/getEggObject
Nov 2, 2023
Merged

feat: getObject support MultiInstanceProto#161
fengmk2 merged 1 commit intomasterfrom
feat/getEggObject

Conversation

@killagu
Copy link
Contributor

@killagu killagu commented Nov 2, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (585e599) 92.50% compared to head (6d4e452) 92.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   92.50%   92.44%   -0.06%     
==========================================
  Files         233      233              
  Lines        4935     4940       +5     
  Branches      550      528      -22     
==========================================
+ Hits         4565     4567       +2     
- Misses        370      373       +3     
Files Coverage Δ
plugin/tegg/app/extend/application.ts 95.00% <100.00%> (+1.97%) ⬆️
plugin/tegg/app/extend/context.ts 88.23% <100.00%> (ø)
core/runtime/src/factory/EggContainerFactory.ts 84.21% <63.63%> (-9.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 added the enhancement New feature or request label Nov 2, 2023
@fengmk2 fengmk2 merged commit 1a24e48 into master Nov 2, 2023
@fengmk2 fengmk2 deleted the feat/getEggObject branch November 2, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants